bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Richard Hansen]

[-- Attachment #1.1.1: Type: text/plain, Size: 3668 bytes --]

GTK toolbar button icon sizes are inconsistent on my Linux KDE system.  This causes the toolbar height to change when the buttons change.  In addition to being visually annoying, the bouncing effect causes a mouse click to turn into a drag event if the click causes the toolbar buttons to change.

See the attached animated gif for an example of the inconsistency.

Also see bug#56607.


In GNU Emacs 29.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0)
  of 2022-07-17 built on sprinkles
Repository revision: 81a39987224989774a3f14b70e78cc36722175c5
Repository branch: info-mode
System Description: Ubuntu 20.04.4 LTS

Configured using:
  'configure --with-modules=yes --with-x=yes --with-x-toolkit=gtk3
  --with-xwidgets=yes --with-pgtk --enable-checking=yes,glyphs
  --enable-check-lisp-object-type 'CFLAGS=-O0 -g3''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY
PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS XIM XWIDGETS GTK3 ZLIB

Important settings:
   value of $LC_MONETARY: en_US.UTF-8
   value of $LC_NUMERIC: en_US.UTF-8
   value of $LC_TIME: root.UTF-8
   value of $LANG: en_US.UTF-8
   value of $XMODIFIERS: @im=ibus
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   show-paren-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   line-number-mode: t
   indent-tabs-mode: t
   transient-mark-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
faces cus-face macroexp files window text-properties overlay sha1 md5
base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads xwidget-internal dbusbind
inotify dynamic-setting system-font-setting font-render-setting cairo
gtk pgtk lcms2 multi-tty make-network-process emacs)

Memory information:
((conses 16 35569 9757)
  (symbols 48 5067 0)
  (strings 32 13278 1788)
  (string-bytes 1 427136)
  (vectors 16 9165)
  (vector-slots 8 145065 15347)
  (floats 8 21 23)
  (intervals 56 210 0)
  (buffers 992 10))

[-- Attachment #1.1.2: animation.gif --]
[-- Type: image/gif, Size: 39651 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Lars Ingebrigtsen]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

Richard Hansen <rhansen@rhansen.org> writes:

> GTK toolbar button icon sizes are inconsistent on my Linux KDE system.  This causes the toolbar height to change when the buttons change.  In addition to being visually annoying, the bouncing effect causes a mouse click to turn into a drag event if the click causes the toolbar buttons to change.
>
> See the attached animated gif for an example of the inconsistency.

That's not what the tool bar line looks like for me under Gtk (Gnome
Shell, Ubuntu):


[-- Attachment #2: Type: image/png, Size: 56807 bytes --]

[-- Attachment #3: Type: text/plain, Size: 145 bytes --]


Where do these icons come from, anyway?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Richard Hansen <rhansen@rhansen.org> writes:

> GTK toolbar button icon sizes are inconsistent on my Linux KDE system.
> This causes the toolbar height to change when the buttons change.  In
> addition to being visually annoying, the bouncing effect causes a
> mouse click to turn into a drag event if the click causes the toolbar
> buttons to change.
>
> See the attached animated gif for an example of the inconsistency.

Which icon theme do you have enabled?  It looks like a bug in that, and
not in Emacs.

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Richard Hansen]

[-- Attachment #1.1: Type: text/plain, Size: 471 bytes --]

On 7/18/22 09:42, Po Lu wrote:
> Which icon theme do you have enabled?

Breeze Icons v5.68.0 (https://invent.kde.org/frameworks/breeze-icons/-/tree/v5.68.0) from the Ubuntu 20.04 breeze-icon-theme package.  I upgraded to v5.92 and they are still inconsistent.

If I switch to the GNOME icon theme then the icon sizes are consistent.

> It looks like a bug in that, and not in Emacs.

I've never noticed toolbar icon issues in any other app.

Thanks,
Richard

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Richard Hansen <rhansen@rhansen.org> writes:

> If I switch to the GNOME icon theme then the icon sizes are
> consistent.

Then it's a bug in the KDE icon theme, probably with `help-browser'.

> I've never noticed toolbar icon issues in any other app.

Emacs uses many icons that most other programs don't even think of, so
that's expected.

I suggest placing

  (setq x-gtk-stock-map nil)

in your early-init.el file, to make Emacs use built in tool bar icons
instead.

If that works for you, I'll add an entry in etc/PROBLEMS and close this
bug.

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Richard Hansen]

[-- Attachment #1.1: Type: text/plain, Size: 792 bytes --]

On 7/18/22 20:53, Po Lu wrote:
> Richard Hansen <rhansen@rhansen.org> writes:
> 
>> If I switch to the GNOME icon theme then the icon sizes are 
>> consistent.
> 
> Then it's a bug in the KDE icon theme, probably with `help-browser'.
> 
>> I've never noticed toolbar icon issues in any other app.
> 
> Emacs uses many icons that most other programs don't even think of, so 
> that's expected.

OK.  I'll dig into the icon theme to see if I can figure out what's going wrong and report the issue to them.

> 
> I suggest placing
> 
>    (setq x-gtk-stock-map nil)
> 
> in your early-init.el file, to make Emacs use built in tool bar icons 
> instead.
> 
> If that works for you, I'll add an entry in etc/PROBLEMS and close this 
> bug.

Yes, that works.  Thank you!

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Richard Hansen <rhansen@rhansen.org> writes:

> Yes, that works.  Thank you!

Thanks for testing.

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Richard Hansen]

[-- Attachment #1.1: Type: text/plain, Size: 168 bytes --]

I just found:

https://bugs.kde.org/show_bug.cgi?id=353496
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21659
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23847

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Lars Ingebrigtsen]

Richard Hansen <rhansen@rhansen.org> writes:

> Breeze Icons v5.68.0
> (https://invent.kde.org/frameworks/breeze-icons/-/tree/v5.68.0) from
> the Ubuntu 20.04 breeze-icon-theme package.  I upgraded to v5.92 and
> they are still inconsistent.

I tried switching to breeze on Ubuntu, but I'm still not able to
reproduce the problem.

The bug report over at the Gnome site says:

----
Emacs Is using system-file-manager (an app icon) which is wrong, so, it's an emacs bug not a Breeze bug. If that button is to open the file manager it could use some other action icon.

Adding the icon for this bug, will in turn, bring back the bug where the task manager plasmoid used mono icons.

Please report it to the emacs devs.
----

So I guess we should just fix that?  It's 

    ("etc/images/diropen" . "n:system-file-manager")

in x-win.el and pgtk-win.el that's the culprit, I guess?  Anybody have a
suggestion of a more appropriate icon to use?

(Since I can't reproduce the problem myself, I can't really test.)

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Richard Hansen <rhansen@rhansen.org> writes:
>
>> Breeze Icons v5.68.0
>> (https://invent.kde.org/frameworks/breeze-icons/-/tree/v5.68.0) from
>> the Ubuntu 20.04 breeze-icon-theme package.  I upgraded to v5.92 and
>> they are still inconsistent.
>
> I tried switching to breeze on Ubuntu, but I'm still not able to
> reproduce the problem.
>
> The bug report over at the Gnome site says:
>
> ----
> Emacs Is using system-file-manager (an app icon) which is wrong, so, it's an emacs bug not a Breeze bug. If that button is to open the file manager it could use some other action icon.
>
> Adding the icon for this bug, will in turn, bring back the bug where the task manager plasmoid used mono icons.
>
> Please report it to the emacs devs.
> ----
>
> So I guess we should just fix that?  It's 
>
>     ("etc/images/diropen" . "n:system-file-manager")
>
> in x-win.el and pgtk-win.el that's the culprit, I guess?  Anybody have a
> suggestion of a more appropriate icon to use?
>
> (Since I can't reproduce the problem myself, I can't really test.)

Didn't we already fix this one earlier?

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

>> So I guess we should just fix that?  It's 
>>
>>     ("etc/images/diropen" . "n:system-file-manager")
>>
>> in x-win.el and pgtk-win.el that's the culprit, I guess?  Anybody have a
>> suggestion of a more appropriate icon to use?
>>
>> (Since I can't reproduce the problem myself, I can't really test.)
>
> Didn't we already fix this one earlier?

I may have missed it -- what was the fix?

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I may have missed it -- what was the fix?

I don't know, but it was reported several years ago, which is why I
asked.

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> I may have missed it -- what was the fix?
>
> I don't know, but it was reported several years ago, which is why I
> asked.

Richard Hansen says it's broken now, though?

bug#56627: 29.0.50; Inconsistent toolbar button icon sizes (pgtk)

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Emacs Is using system-file-manager (an app icon) which is wrong, so,
> it's an emacs bug not a Breeze bug. If that button is to open the file
> manager it could use some other action icon.
>
> Adding the icon for this bug, will in turn, bring back the bug where
> the task manager plasmoid used mono icons.
>
> Please report it to the emacs devs.
> ----
>
> So I guess we should just fix that?  It's 
>
>     ("etc/images/diropen" . "n:system-file-manager")

I've now replaced this in Emacs 29.