all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Duy Nguyen <ddnguyen2101@gmail.com>
Cc: Emacs-orgmode@gnu.org
Subject: Re: [PATCH v3] Show org file title in org-clock clocktable
Date: Sat, 20 Aug 2022 14:14:47 +0800	[thread overview]
Message-ID: <87k073o2zs.fsf@localhost> (raw)
In-Reply-To: <CAM=3T05hsdsoziTOyyqB0umjCRJ5pTrxd3n1BHc1zJvNv1tGeg@mail.gmail.com>

Duy Nguyen <ddnguyen2101@gmail.com> writes:

> Thanks for letting me know. The reason I chose that method is because the
> org-macro-templates are not updated immediately after I change the title
> and save the file. However, I think I found a solution using
> org-macro-initialize-templates and org-macro-templates. Please see the
> attached patch. Hope this is OK, otherwise please let me know how to
> improve.

Thanks for the update!
Applied onto main via 2cc2d8f1f with amendments.
I fixed on double space "  " between sentences, removed autoload cookie
(that function is not used outside org-clock), and altered the docstring
making the first line a single sentence and clarifying about the return
value a bit.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2cc2d8f1f6265d12c92b734931f2e3e417276b05

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92


  reply	other threads:[~2022-08-20  6:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 21:54 [Patch] Show org file title in org-clock clocktable Duy Nguyen
2022-08-13  8:00 ` Ihor Radchenko
2022-08-13 10:55   ` Duy Nguyen
2022-08-13 11:35     ` Ihor Radchenko
2022-08-15  6:40       ` [PATCH v2] " Duy Nguyen
2022-08-17  9:34         ` Ihor Radchenko
2022-08-17 18:53           ` [PATCH v3] " Duy Nguyen
2022-08-20  6:14             ` Ihor Radchenko [this message]
2022-08-21 12:06               ` Duy Nguyen
2022-08-28  8:11                 ` Duy Nguyen
2022-08-28  8:33                   ` Duy Nguyen
2022-08-28 11:30                     ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k073o2zs.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=Emacs-orgmode@gnu.org \
    --cc=ddnguyen2101@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.