From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master c0bb1aac10: Fix reader memory leak upon error (bug#56623) Date: Mon, 29 Aug 2022 23:21:20 +0200 Message-ID: <87k06qn3u7.fsf@gnus.org> References: <166178822896.15485.13175695435610050790@vcs2.savannah.gnu.org> <20220829155029.5B5EEC0088A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7556"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mattias =?utf-8?B?RW5nZGVnw4PCpXJk?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 29 23:23:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSmDn-0001kL-AU for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Aug 2022 23:23:03 +0200 Original-Received: from localhost ([::1]:51038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oSmDm-0002S8-AD for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Aug 2022 17:23:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSmCN-0008Tg-By for emacs-devel@gnu.org; Mon, 29 Aug 2022 17:21:35 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:40468) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSmCF-0008OV-S8 for emacs-devel@gnu.org; Mon, 29 Aug 2022 17:21:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1qzQLQtpltT3EGTg/Bl/dWii3MtkCAjpcyEGbIkXmKY=; b=Y0g+4P4vgW2lgXESuT/8f/nHvz 70ONL1VpeUQdMwbUI0Kjy8hEWjWfVX0U6HNywMUIb8zp3ZgSDEoeclT/KoSopCPPFa39Ec9h/5i2m lC6KDizWjo5zfQnCEh1RAcrWACLMkRIwFrPKHemJIe3rpyCJ1s1OqdmBosuIc1bhOioo=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSmC9-0001Rw-BT; Mon, 29 Aug 2022 23:21:23 +0200 In-Reply-To: <20220829155029.5B5EEC0088A@vcs2.savannah.gnu.org> ("Mattias =?utf-8?Q?Engdeg=C3=83=C2=A5rd=22's?= message of "Mon, 29 Aug 2022 11:50:29 -0400 (EDT)") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEVml+Bki6p2lKAq Ljf///8a7Q0qAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YIHRUTG2+tf1kAAAGwSURBVDjLtZNbcgQh CEVFNwDtBhQ30Mr+95YLOj2TqqQqP6GmH+PhDZ3SX4QEl9++iVyJpgjL/H6c+2DqVpf058xv/VIB kOvqes45M5Bye8UB4DCgrpzIX2ccEGLFM4/FW9vBhatYgEvPeXLF+oDc4hU3j0Ue+ljgiMwmPM8A BCC0fRQzA92l1buanfLxBl9wLxygWt2563AAsQmvIVHL5SA0bJUPQAqwazJtAjEkSG6gQ9VJWWOi cDGRyBatgo3HbcPQSzJ0lneQZHYjdiu2mMliYp7MrR4PFsl9FfMxwoSs5QBlpXyjmsgdJvDp4D6V IrjPiZiL5WbeLgfjFrIYi1C1nE5dVqNrMdrE3uZxAFd52o68WzqtuFEBhYWPG6BtX9N3hk8MsHK3 7SuGCEUOE/zgK28L79EGFDmjrWEy96Rf64ECROuJ8gZ8diJIegCWGDtOngHs+AFQU4EHjA2LmFV3 DEkLM5pigZDZGkvFFyKZL8LqGHSM3PX2MkAHSvgPMVy9ni3Zj2kfsvIbYC0+wPgAe3/v9FpE8y65 V43C1yl/Z9XtJ0n2i/w/wOf4m8UXToNzLYBgRBcAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDgt MjlUMjE6MTk6MjcrMDA6MDCky/w/AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA4LTI5VDIxOjE5 OjI3KzAwOjAw1ZZEgwAAAABJRU5ErkJggg== X-Now-Playing: Michael Hurley, Ida Con Snock & Ida's _Ida Con Snock_: "Hoot Owls" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294316 Archived-At: Mattias Engdeg=C3=83=C2=A5rd writes: > Fix reader memory leak upon error (bug#56623) > > Reported by Tom Gillespie; error found by Greg Hendershott. > > * src/lread.c (read_stack_reset): New. > (read0): Reset read stack when unwinding from an error. I have no idea whether it's this commit or not, but fns-tests.el is segfaulting now (and it didn't yesterday). I haven't tried to debug any further; perhaps it's obvious what the problem may be. double free or corruption (!prev) Backtrace: ../src/emacs(+0x18e2b1)[0x5556c76b12b1] ../src/emacs(+0x4846c)[0x5556c756b46c] ../src/emacs(+0x48999)[0x5556c756b999] ../src/emacs(+0x18c79d)[0x5556c76af79d] ../src/emacs(+0x18c889)[0x5556c76af889] /lib/x86_64-linux-gnu/libpthread.so.0(+0x14140)[0x7f7457a41140] /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x141)[0x7f74576d5ce1] /lib/x86_64-linux-gnu/libc.so.6(abort+0x123)[0x7f74576bf537] /lib/x86_64-linux-gnu/libc.so.6(+0x7e768)[0x7f7457718768] /lib/x86_64-linux-gnu/libc.so.6(+0x85a5a)[0x7f745771fa5a] /lib/x86_64-linux-gnu/libc.so.6(+0x8709c)[0x7f745772109c] ../src/emacs(+0x2a0719)[0x5556c77c3719] ../src/emacs(+0x1f7978)[0x5556c771a978] ../src/emacs(+0x228525)[0x5556c774b525] ../src/emacs(+0x229a20)[0x5556c774ca20] ../src/emacs(+0x1f8473)[0x5556c771b473] ../src/emacs(+0x22a380)[0x5556c774d380] ../src/emacs(+0x22af7e)[0x5556c774df7e] ../src/emacs(+0x23d645)[0x5556c7760645] ../src/emacs(+0x1fd737)[0x5556c7720737] ../src/emacs(+0x1fc18d)[0x5556c771f18d] ../src/emacs(+0x1fe767)[0x5556c7721767] ../src/emacs(+0x1f6cf7)[0x5556c7719cf7] ../src/emacs(+0x16d6d6)[0x5556c76906d6] ../src/emacs(+0x1f6c51)[0x5556c7719c51] ../src/emacs(+0x16cce8)[0x5556c768fce8] ../src/emacs(+0x173bb3)[0x5556c7696bb3] ../src/emacs(+0x173f2c)[0x5556c7696f2c] ../src/emacs(+0x51190)[0x5556c7574190] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xea)[0x7f74576c0d0a] ../src/emacs(+0x516ba)[0x5556c75746ba]