From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.devel Subject: Re: src/Makefile unhelpful Date: Sat, 17 Sep 2022 12:41:28 -0400 Message-ID: <87k06254xz.fsf@md5i.com> References: <875yhui674.fsf@gnus.org> <8735cy5dg9.fsf@yahoo.com> <83bkrj45lr.fsf@gnu.org> <87zgf12036.fsf@gnus.org> <2b58b8f5425fc083d4ad@heytings.org> <877d251540.fsf@gnus.org> <0b5f34d9bc43b17dd0df@heytings.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34357"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Gregory Heytings , Lars Ingebrigtsen , Eli Zaretskii , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 17 18:44:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZavq-0008lT-KO for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Sep 2022 18:44:43 +0200 Original-Received: from localhost ([::1]:40728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZavp-0005uR-Cp for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Sep 2022 12:44:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZaso-0004gj-5a for emacs-devel@gnu.org; Sat, 17 Sep 2022 12:41:34 -0400 Original-Received: from md5i.com ([75.151.244.229]:38756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZasm-00040B-Nb; Sat, 17 Sep 2022 12:41:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=obP1U1lL9zZLb+gRS8GABIbfG9+xiQ3Nj/P7QabOjig=; b=l55hK6EVynrYvBksRzQSJ5A7P9 O0p84PwPB058s1OpEMooeFlq6ZJUzSBsyoBRYHtkT4dYYCXWt3gGpG0knPv02xNL/mkH8yYZLzDDF BSHrP+YDrT+PSLLR5H/LkAY7l; Original-Received: from abode ([192.168.177.1] helo=miko) by md5i.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1oZasi-003a5p-2D; Sat, 17 Sep 2022 12:41:28 -0400 In-Reply-To: (Alan Mackenzie's message of "Sat, 17 Sep 2022 11:20:40 +0000") Received-SPF: pass client-ip=75.151.244.229; envelope-from=mwd@md5i.com; helo=md5i.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295532 Archived-At: Alan Mackenzie writes: > Hello, Gregory. > > On Sat, Sep 17, 2022 at 10:46:24 +0000, Gregory Heytings wrote: > >> Complete patch attached, comments welcome. > > Just a small point in English usage: > >> I added a (minimal) sanity check, too. I remember at least one case when >> make "failed to fail", it returned 0 even though the build did in fact not >> succeed. > >> + >> +# ADVICE-ON-FAILURE-BEGIN >> +# You might consider to: >> +# - run "make bootstrap", which might fix the problem >> +# - run "git clean -fdx" and run "make" again, which might fix >> +# the problem if it was not fixed by "make bootstrap" >> +# !BEWARE! "git clean -fdx" restores the local repository in its >> +# !BEWARE! pristine state, it deletes all local changes and all >> +# !BEWARE! untracked files >> +# - run "make V=1", which displays the full commandes invoked by >> +# make, to further investigate the problem >> +# ADVICE-ON-FAILURE-END >> + > > The verb "consider" takes a gerund (or noun), not an infinitive. So the > above really ought to be: > > You might consider: > - running .... > > , with the other "run"s being changed to "running", too. Alternatively, > one could use instead the verb "try", which can take an infinitive (or a > gerund or noun ;-). Also, for completeness sake, "commands" instead of "commandes". -- Michael Welsh Duggan (md5i@md5i.com)