Re: [PATCH] Prevent blocked tasks from being archived

[Ihor Radchenko <yantar92@posteo.net>]

Ankit Raj Pandey <arpandeytest@gmail.com> writes:

> When org-archive-mark-done is enabled, org silently fails on setting the
> TODO state of the archived headline to DONE if the task is blocked.
>
> This patch changes that behavior so the headline is prevented from being
> archived in the first place. Instead, org displays a message about why
> the task is blocked (this message comes from org-todo).

Thanks for the patch, and sorry for the late reply.

I see that you moved changing the todo state code before we switch to
the archive buffer. It is not safe. If something goes wrong during
archive process after changing the todo state, the todo will not be
recovered even though archiving fails.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>