From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.bugs Subject: bug#59029: Dumping Emacs crashes when buffers have overlays Date: Tue, 08 Nov 2022 07:59:45 -0800 Message-ID: <87k045mo7i.fsf_-_@rfc20.org> References: <87leoqwc4o.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31249"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59029@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 08 17:00:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osR1l-0007ur-4g for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Nov 2022 17:00:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osR1C-0004Y9-G1; Tue, 08 Nov 2022 11:00:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osR19-0004XI-9r for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 11:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osR18-0007Vv-VB for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 11:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1osR18-0004SL-OD for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 11:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59029 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59029-submit@debbugs.gnu.org id=B59029.166792319817095 (code B ref 59029); Tue, 08 Nov 2022 16:00:02 +0000 Original-Received: (at 59029) by debbugs.gnu.org; 8 Nov 2022 15:59:58 +0000 Original-Received: from localhost ([127.0.0.1]:38028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osR14-0004Re-EG for submit@debbugs.gnu.org; Tue, 08 Nov 2022 10:59:58 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:47395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osR11-0004RP-M3 for 59029@debbugs.gnu.org; Tue, 08 Nov 2022 10:59:56 -0500 Original-Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 9C48020011; Tue, 8 Nov 2022 15:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1667923189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0LH7OQwZyByiMUDprHXxkNGtDz2WEdynVi8xxzAch/8=; b=lhibipGqkOabcrCzJWFtNy4IQCYp4zHiOC5A9IeWZXO6/UilpfrWTQeDrcqiCFYxnhIrW2 XLeuoc+d2FKb/pTZJPtY5BE1az4gxSsI+fStmdektfMPY6sy1Emh76B6WWhQYHVYx3/gtS Ak/loqR8T/P/W8YlOJnQEGWuTpB5AqL1OWXPCgpfE5eHPIb3LA0vxc7RAOps1efG/tZPQQ n0+Mvk3TOk6BlC6cVGdI6cU3tN9/EmLTXZGvCm0e4BYd2ZEGT5YS98fWWWKoTB6dpy5fKy HrqmhQUfzpN/dB6RLOEhuXvYrVohYSXR8AaxnDaqqOSSUjyo0f7Qy/u9+zyoYA== Original-Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1osR0r-001Ah2-2i; Tue, 08 Nov 2022 07:59:45 -0800 In-Reply-To: (Stefan Monnier's message of "Sat, 05 Nov 2022 16:38:47 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247344 Archived-At: Stefan Monnier writes: >> See the code for dump_interval_node() in pdumper.c below. > > This code is indeed incorrect. I have time to work on this, but I don't have a clear path and would like to hear opinions. I see two options. a) Drop support for dumping overlays in buffers, as if `delete-all-overlays' were called for all buffers before dumping. Fix involves relaxing the abort() calls to merely print warnings. b) Restore support, and test it. For (b) I'm not keen on wiring up a single-purpose test under test/* somewhere just to test pdumping with overlays. How about hooking in to loadup.el to populate a dummy buffer with overlays before dumping? Emacs could delete it early, so it wouldn't be gone before users noticed. Or, are there other alternatives I'm missing?