From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#59314: 29.0.50; EUDC and message-mode header completion Date: Wed, 16 Nov 2022 17:16:33 -0800 Message-ID: <87k03uz8ge.fsf@ericabrahamsen.net> References: <87a64q7p25.fsf@ericabrahamsen.net> <878rka1y4n.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30113"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alexander Adolf , 59314@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 17 02:17:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovTWy-0007bw-6z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Nov 2022 02:17:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovTWb-0000ld-6A; Wed, 16 Nov 2022 20:17:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovTWZ-0000kB-38 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 20:17:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovTWY-0000u8-Qy for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 20:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovTWY-0001w3-DT for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 20:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Nov 2022 01:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59314 X-GNU-PR-Package: emacs Original-Received: via spool by 59314-submit@debbugs.gnu.org id=B59314.16686478057410 (code B ref 59314); Thu, 17 Nov 2022 01:17:02 +0000 Original-Received: (at 59314) by debbugs.gnu.org; 17 Nov 2022 01:16:45 +0000 Original-Received: from localhost ([127.0.0.1]:58541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovTWG-0001vR-Gj for submit@debbugs.gnu.org; Wed, 16 Nov 2022 20:16:44 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:36844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovTWD-0001vE-GL for 59314@debbugs.gnu.org; Wed, 16 Nov 2022 20:16:43 -0500 Original-Received: from localhost (unknown [76.135.104.211]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id EAA70FA59E; Thu, 17 Nov 2022 01:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1668647795; bh=7nraG8W41v20Iu0w4cCWRRpiRdodFEm6rf4Jqma+UrA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=js9Ns4DA5zzpFGwl6jq1szgDfJlQIzbmx1wpT+czUPja1vB5I5DRpadgJjiE9rrOp s3C3BXWHc7zKKlRyrgZHKl6bzOhppZDOuemh9VVrwkzz5dzgRY6v9k1q/JgKtnqwUo F/oBTD6ASJZvQ+oGlstmFuTVx8QG3WfXXyZgDMwA= In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 16 Nov 2022 15:54:11 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248062 Archived-At: On 11/16/22 15:54 PM, Thomas Fitzsimmons wrote: > Hi Eric, > > Eric Abrahamsen writes: > >> On 11/16/22 14:18 PM, Thomas Fitzsimmons wrote: >>> Hi Eric, >>> >>> Thanks for filing this. >>> >>> Eric Abrahamsen writes: >>> >>>> Address completion in message-mode has stopped working in master, >>>> possibly as a result of 0e25a39e69acca0324c326ea8e46b1725594bff5. This >>>> has been reported for several contact-management backends that expect to >>>> have their completions available with . >>>> >>>> `completion-at-point-functions' contains '(eudc-capf-complete >>>> message-completion-function t) at this point -- `eudc-capf-complete' >>>> returns no matches, and no other functions in the list are consulted. >>> >>> I just checked and I didn't think the recent patch I pushed, >>> 0e25a39e6..., should have affected completion-at-point-functions. It >>> did change the default of eudc-server-hotlist from `nil' to >>> `(("localhost" . ecomplete) ("localhost" . mailabbrev))". I thought >>> that should only affect EUDC users who have not customized >>> eudc-server-hotlist. >>> >>> `eudc-capf-complete' was added to `message-mode' in commit >>> 620ac6735... I'm pretty sure that commenting out this line in >>> message.el will restore prior behaviour, but I don't yet know what prior >>> behaviour should be (see below). >>> >>> (add-hook 'completion-at-point-functions #'message-completion-function nil t) >>> >>>> On gnus.general, someone using BBDB and corfu reported that this recipe >>>> fixed the problem: >>>> >>>> (setq eudc-server-hotlist '(("localhost" . bbdb))) >>>> >>>> (add-hook 'message-mode-hook >>>> (lambda () >>>> (setq-local completion-at-point-functions >>>> (delq 'message-completion-function >>>> completion-at-point-functions)))) >>>> >>>> Someone else *not* using corfu reported that that didn't work for them. >>>> Dunno. >>> >>> I'm not sure what the out-of-the-box behaviour here is meant to be. Can >>> you make a recipe starting from "emacs -Q" (including adding dummy email >>> addresses somewhere) that makes completion work how you want it to? For >>> me: >>> >>> emacs -Q >>> C-x m TAB >>> >>> inserts four spaces and prints in *Messages*: >>> >>> Loading eudcb-ecomplete...done >>> Loading eudcb-mailabbrev...done >>> >>> (Those are new, due to 0e25a39e6... but I thought should be harmless.) >> >> Yuck, it's been a long time since I looked at this... >> >> In emacs -Q, message-mode `completion-at-point-functions' is: >> >> (eudc-capf-complete message-completion-function t) >> >> Actually that's what it is in my regular Emacs, as well. All I'd need >> for EBDB (and BBDB and everything else) is for >> `message-completion-function' to get called, which it isn't. I believe >> you could allow this by having `eudc-capf-complete' return nil, or have >> `eudc-capf-message-expand-name' return a `(list beg end )' >> structure that includes the prop `:exclusive 'no' at the end of it. That >> would allow a fallthrough to the next function. > > Ah, OK, that's what happened then. The most recent patch I pushed made > `eudc-server-hotlist' non-nil by default, which makes > `eudc-capf-message-expand-name' do something other than return nil. > > Can you try just (setq eudc-server-hotlist nil) and confirm that avoids > the breakage? > > If it does, I'll revert that part of the patch for now. Also, I didn't mean that rant to be directed at you! I realized it might have come off that way.