From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#59314: 29.0.50; EUDC and message-mode header completion Date: Mon, 21 Nov 2022 16:15:06 -0800 Message-ID: <87k03nx2t1.fsf@ericabrahamsen.net> References: <87a64q7p25.fsf@ericabrahamsen.net> <878rka1y4n.fsf@ericabrahamsen.net> <87sfigx58k.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="905"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alexander Adolf , 59314@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 01:16:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxGxd-000AZ1-Jo for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 01:16:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxGxK-0002tI-Ar; Mon, 21 Nov 2022 19:16:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxGxG-0002t1-LG for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 19:16:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxGxG-00085i-3k for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 19:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxGxF-0005Ag-JM for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 19:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 00:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59314 X-GNU-PR-Package: emacs Original-Received: via spool by 59314-submit@debbugs.gnu.org id=B59314.166907611919828 (code B ref 59314); Tue, 22 Nov 2022 00:16:01 +0000 Original-Received: (at 59314) by debbugs.gnu.org; 22 Nov 2022 00:15:19 +0000 Original-Received: from localhost ([127.0.0.1]:49145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxGwZ-00059k-6R for submit@debbugs.gnu.org; Mon, 21 Nov 2022 19:15:19 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:59594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxGwU-00059Q-9y for 59314@debbugs.gnu.org; Mon, 21 Nov 2022 19:15:18 -0500 Original-Received: from localhost (unknown [76.135.104.211]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id CA04FFA08D; Tue, 22 Nov 2022 00:15:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1669076108; bh=aW8QHpPWn2xdlLTUL+BGInX/dEkLVCgas7t6V41onT8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=x62G/PVHiv6akdIM2FBMPudO1JU2K1Lrsx1UcBYiLJE+wI3Gx8c8naefR90YNcF8v XUScelq56TQ8q8a+Mch3U/IhodYUcfAffRNRKgINma0b3oP/y92Mb8m+pWoTxR0y1/ jz8wuIIvoNW0TnnJNlKtrQWF2RGQDCHf+0vjnrMw= In-Reply-To: (Thomas Fitzsimmons's message of "Sat, 19 Nov 2022 02:42:27 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248581 Archived-At: Thomas Fitzsimmons writes: [...] > That's the extent of my email completion setup. I think the only reason > this setup doesn't generalize (assuming an EUDC EBDB backend in your > case) is that other people like different UIs, e.g., when the same > prefix expands to multiple possible addresses (as you alluded to), what > UI should one use to select? I use the UI provided by EUDC. > > Anyway, tonight I did manage to add ERT tests for the EUDC LDAP backend. > Can you try: > > make -C test lisp/net/eudc-tests.log No love! Running 11 tests (2022-11-21 16:04:40-0800, selector `(not (or (tag :unstable) (tag :nativecomp)))') passed 1/11 eudc--plist-member (0.000396 sec) passed 2/11 eudc-lax-plist-get (0.000433 sec) passed 3/11 eudc-plist-get (0.000417 sec) passed 4/11 eudc-plist-member (0.000390 sec) passed 5/11 eudc-test-make-address (0.000151 sec) passed 6/11 eudc-test-rfc5322-quote-phrase (0.000067 sec) passed 7/11 eudc-test-rfc5322-valid-comment-p (0.000760 sec) skipped 8/11 eudcb-bbdb (0.000102 sec) passed 9/11 eudcb-ecomplete (0.007451 sec) Loading eudcb-ldap... Parsing results... Parsing results... done Parsing results... Parsing results... done Test eudcb-ldap backtrace: signal(error ("No match")) apply(signal (error ("No match"))) (setq value-640 (apply fn-638 args-639)) (unwind-protect (setq value-640 (apply fn-638 args-639)) (setq form- (if (unwind-protect (setq value-640 (apply fn-638 args-639)) (setq f (let (form-description-642) (if (unwind-protect (setq value-640 (app (let ((value-640 'ert-form-evaluation-aborted-641)) (let (form-descr (let* ((fn-638 #'equal) (args-639 (condition-case err (let ((signal- (let ((ldap-process (start-process "slapd" "*slapd*" "/usr/sbin/slap (closure (t) nil (let ((value-636 (gensym "ert-form-evaluation-abort ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name eudcb-ldap :documentation "Test the L ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/eudc-tests.el" " command-line() normal-top-level() Test eudcb-ldap condition: (error "No match") FAILED 10/11 eudcb-ldap (1.024022 sec) at lisp/net/eudc-tests.el:271 Parsing /home/eric/dev/emacs/test/lisp/net/eudc-resources/mailrc... Parsing /home/eric/dev/emacs/test/lisp/net/eudc-resources/mailrc... done passed 11/11 eudcb-mailabbrev (0.002174 sec) Ran 11 tests, 9 results as expected, 1 unexpected, 1 skipped (2022-11-21 16:04:41-0800, 1.151547 sec) 1 unexpected results: FAILED eudcb-ldap 1 skipped results: SKIPPED eudcb-bbdb > on your machine to confirm they work for you? You need /usr/sbin/slapd > installed. > > I'll work on adding EUDC BBDB backend tests, and I may write an EBDB > EUDC backend. > > Once I have that, I'll be able to extract all the configuration > resources (like .mailrc, ecompleterc, etc.) into a tarball. Then we can > use that tarball to debug/redesign out-of-the-box completion scenarios, > starting from "emacs -Q + tarball", "emacs -Q + EBDB + tarball", > "emacs -Q + BBDB + tarball", etc. > > Without starting from "emacs -Q", it's impossible for me to know what I > might break in other people's configurations, when making changes to > message-mode's default completion code. I've already said this, but I don't think we should be pushing things in a direction that relies any external package or its particular behavior. The capf machinery should be enough, and that's very clearly defined. Eric