From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Florian Weimer Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: master ef14acf: Make nnml handle invalid non-ASCII headers more consistently Date: Mon, 19 Dec 2022 18:27:09 +0100 Message-ID: <87k02nxq1e.fsf@oldenburg.str.redhat.com> References: <20210122180801.14756.84264@vcs0.savannah.gnu.org> <20210122180802.F0A1E20A10@vcs0.savannah.gnu.org> <874jtvq8c2.fsf@oldenburg.str.redhat.com> <83k02qiicb.fsf@gnu.org> <87bko26ptd.fsf@oldenburg.str.redhat.com> <83r0wygh9b.fsf@gnu.org> <87k02nze8a.fsf@oldenburg.str.redhat.com> <83zgbjcoeq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37963"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) Cc: larsi@gnus.org, eric@ericabrahamsen.net, emacs-devel@gnu.org, ding@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 19 18:28:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7Jvk-0009dJ-TW for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Dec 2022 18:28:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7Jv8-0005Ei-9i; Mon, 19 Dec 2022 12:27:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Jv7-0005Ea-1Z for emacs-devel@gnu.org; Mon, 19 Dec 2022 12:27:21 -0500 Original-Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7Jv5-0003yp-Ir for emacs-devel@gnu.org; Mon, 19 Dec 2022 12:27:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671470838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KI95RB+vYr6OdQ9oeyWAbPsE6grcqsYevkiZVS2rJRc=; b=BxiVKpGGw4H6eN98ydDt3C8aowdRzAxsaRl18wsBgTNiHGrLP2XxQLlq1KLtaYbJ6PEADv +Y1hbFGf7si7YI5AJofCMXDjY9/7wXXj5/w4r+9cHdNU453qoTBLcXI5EKrpIH1MlyoOsN quIMKZ6bNlVgDqZ5ygukaZ4kcRh9N24= Original-Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-128-lCkMkmbNPqSqTLFwKvnAbA-1; Mon, 19 Dec 2022 12:27:13 -0500 X-MC-Unique: lCkMkmbNPqSqTLFwKvnAbA-1 Original-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EFDA21C02D3C; Mon, 19 Dec 2022 17:27:12 +0000 (UTC) Original-Received: from oldenburg.str.redhat.com (unknown [10.2.16.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B97EB2166B26; Mon, 19 Dec 2022 17:27:11 +0000 (UTC) In-Reply-To: <83zgbjcoeq.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Dec 2022 19:07:57 +0200") X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=fweimer@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301662 gmane.emacs.gnus.general:91037 Archived-At: * Eli Zaretskii: >> As I expected, I could reproduce the issue with new mail. I'm happy to >> report that replacing nnml--encode-headers with your new version fixes >> the issue. > > Thanks, so I've now installed this on the emacs-29 branch, for the > upcoming Emacs 29.1. It's a denial-of-service issue, so it should be backported to 28 if possible, too. >> Going back to older mail, I see that previously the From: header was >> written in encoded form to .overview (slightly wrapped to avoid SMTP >> issues): >>=20 >> 8523 Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec= .' -> 'hello3.spec' =3D?utf-8?b?572X5YuH5YiaKFlvbmdnYW5nIEx1bykgdmlhIEVsZnV= 0aWxzLWRldmVs?=3D Thu, 24 Nov 2022 16:27:56= +0800 >> <20220920084307.1696-1-luoyonggang@gmail.com> <20220920084307.1696-2-l= uoyonggang@gmail.com> <20221019194930.GC24703@r= edhat.com> <3bf19d05c8976411432709fae1cc2bcc2d21d700.camel@klomp.org> >> <586fbfd512763e539f0d06e8ffa308da34be5368.camel@wildebeest.org> 705 32= Xref: oldenburg.str.redhat.com lists.sourceware.elfutils-devel:8523 Cc: "F= rank Ch. Eigler" , elfutils-devel@sourceware.org To: Mark = Wielaard >>=20 >> Now it uses unencoded form: >>=20 >> 8762 Re: [PATCH v2 13/16] lib: isatty is not available on windows =E7=BD= =97=E5=8B=87=E5=88=9A(Yonggang Luo) via Elfutils-devel Mon, 19 Dec 2022 20:32:48 +0800 <20221217165213.152-1-luoyonggang@gma= il.com> >> <20221217165213.152-14-luoyonggang@gmail.com> 1074 43 Xref: oldenburg.= str.redhat.com lists.sourceware.elfutils-devel:8762 To: elfutils-devel@sour= ceware.org > > Is that a problem? I think this was part of the reason for that > change in nnml.el. I don't know. >> I assume that there is some protection in place that tabs are not >> possible here? > > Tabs where, and what kind of protection are we talking about? The .overview file is in tab-separated-values format, and I think the code is supposed to replace tabs with spaces before the lines are written. But mail-encode-encoded-word-string/rfc2047-encode-string generally does not replace tabs, so your change shouldn't make things worse at least. Thanks, Florian