From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: master ef14acf: Make nnml handle invalid non-ASCII headers more consistently Date: Mon, 19 Dec 2022 09:48:15 -0800 Message-ID: <87k02ns2sg.fsf@ericabrahamsen.net> References: <20210122180801.14756.84264@vcs0.savannah.gnu.org> <20210122180802.F0A1E20A10@vcs0.savannah.gnu.org> <874jtvq8c2.fsf@oldenburg.str.redhat.com> <83k02qiicb.fsf@gnu.org> <87bko26ptd.fsf@oldenburg.str.redhat.com> <83r0wygh9b.fsf@gnu.org> <87k02nze8a.fsf@oldenburg.str.redhat.com> <83zgbjcoeq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24999"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Florian Weimer , larsi@gnus.org, emacs-devel@gnu.org, ding@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 19 18:49:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7KG8-0006Fm-8T for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Dec 2022 18:49:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7KFS-0004AP-0E; Mon, 19 Dec 2022 12:48:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KFQ-0004AC-8s for emacs-devel@gnu.org; Mon, 19 Dec 2022 12:48:20 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KFO-0000Pf-ID; Mon, 19 Dec 2022 12:48:19 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 89B4AFA011; Mon, 19 Dec 2022 17:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1671472096; bh=xL1qa22fCxUmUk0m7M51zUmqJjzzWlXg14rm57R6y0g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Hj7x4KZggUkIlp7sfj4jU1MQE6MjSuArXdn3P31pj6DMBTmXjIVkvmYtdHZSpNYmb q1H8DLkTH45XPN8lgw15nesNMBMvVLbd9pT59hm+Gk47jdJURMwMgvee2Pnfzl9hno pZ0+dG0++rgWuJ0UyyZ4oncRLG2dMexUMdpm89UM= In-Reply-To: <83zgbjcoeq.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Dec 2022 19:07:57 +0200") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301664 gmane.emacs.gnus.general:91039 Archived-At: On 12/19/22 19:07 PM, Eli Zaretskii wrote: >> From: Florian Weimer >> Cc: larsi@gnus.org, eric@ericabrahamsen.net, emacs-devel@gnu.org, >> ding@gnus.org >> Date: Mon, 19 Dec 2022 14:59:17 +0100 >>=20 >> > I'm not sure this is related. I was talking about the missing SPC >> > character before the parentheses. But I know very little about this >> > stuff, so maybe I'm just misunderstanding you. >>=20 >> I was responding to =E2=80=9Cthis From header is invalid=E2=80=9D. I'm = not sure if the >> original message is actually malformed. > > Ah, okay. I'm not sure, either, although I don't think I've ever seen > such addresses. But I'm no expert. Maybe rfc2047.el needs to be more > tolerant and less dependent on whitespace; I'll leave that to experts. > But even if there's nothing wrong with this particular header, I think > you will agree that signaling and error and thus failing the entire > storage of the message is not TRT, especially since the change which > causes this was done for basically aesthetic reasons. Falling back to > previous behavior in these cases is better, I think. > >> As I expected, I could reproduce the issue with new mail. I'm happy to >> report that replacing nnml--encode-headers with your new version fixes >> the issue. > > Thanks, so I've now installed this on the emacs-29 branch, for the > upcoming Emacs 29.1. > >> Going back to older mail, I see that previously the From: header was >> written in encoded form to .overview (slightly wrapped to avoid SMTP >> issues): >>=20 >> 8523 Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' >> 'hello3.spec.' -> 'hello3.spec' >> =3D?utf-8?b?572X5YuH5YiaKFlvbmdnYW5nIEx1bykgdmlhIEVsZnV0aWxzLWRldmVs?=3D >> Thu, 24 Nov 2022 16:27:56 +0800 >> >> <20220920084307.1696-1-luoyonggang@gmail.com> >> <20220920084307.1696-2-luoyonggang@gmail.com> >> >> >> <20221019194930.GC24703@redhat.com> >> <3bf19d05c8976411432709fae1cc2bcc2d21d700.camel@klomp.org> >> <586fbfd512763e539f0d06e8ffa308da34be5368.camel@wildebeest.org> >> 705 32 Xref: oldenburg.str.redhat.com >> lists.sourceware.elfutils-devel:8523 Cc: "Frank Ch. Eigler" >> , elfutils-devel@sourceware.org To: Mark Wielaard >> >>=20 >> Now it uses unencoded form: >>=20 >> 8762 Re: [PATCH v2 13/16] lib: isatty is not available on windows =E7=BD= =97 >> =E5=8B=87=E5=88=9A(Yonggang Luo) via Elfutils-devel >> Mon, 19 Dec 2022 20:32:48 +0800 >> >> <20221217165213.152-1-luoyonggang@gmail.com> >> <20221217165213.152-14-luoyonggang@gmail.com> 1074 43 Xref: >> oldenburg.str.redhat.com lists.sourceware.elfutils-devel:8762 To: >> elfutils-devel@sourceware.org > > Is that a problem? I think this was part of the reason for that > change in nnml.el. It would definitely be a problem to change the on-disk representation of data in the .overview files! Lots of code depends on a very specific format for those files; I've broken things badly in the past by removing header encoding there.