From: Robert Pluim <rpluim@gmail.com>
To: Yuan Fu <casouri@gmail.com>
Cc: 59945@debbugs.gnu.org, cpbotha@vxlabs.com,
Eli Zaretskii <eliz@gnu.org>,
59945-done@debbugs.gnu.org
Subject: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist
Date: Wed, 21 Dec 2022 18:25:58 +0100 [thread overview]
Message-ID: <87k02kllcp.fsf@gmail.com> (raw)
In-Reply-To: <7B3A9410-A4E4-4B32-83CE-FADB9588C7A7@gmail.com> (Yuan Fu's message of "Tue, 20 Dec 2022 20:48:58 -0800")
>>>>> On Tue, 20 Dec 2022 20:48:58 -0800, Yuan Fu <casouri@gmail.com> said:
Yuan> "Charl P. Botha" <cpbotha@vxlabs.com> writes:
>> On Fri, Dec 16, 2022, at 16:11, Robert Pluim wrote:
>>>>>>>> On Fri, 16 Dec 2022 07:58:46 +0200, "Charl P. Botha" <cpbotha@vxlabs.com> said:
Charl> I followed the instructions at
Charl>
>>> https://www.gnu.org/software/emacs/manual/html_node/emacs/Sending-Patches.html
Charl> which said to use "git format-patch master" and include
>>> either inline
Charl> (which I did) or as a mime attachment.
>>>
>>> Not quite. You sent the result of 'git format-patch master' as an
>>> email, not inline in an email (presumably with 'git send-email'). That
>>> shouldnʼt matter, because 'git apply' should work in either case, but
>>> attachments are sometimes easier to work with.
>>
>> Thank you for the correction, Robert! I thought that sending the
>> output of `git format-patch master` as a plain-text email was what was
>> meant by "inline". I'm sorry about this, I'll stick to attachments in
>> the future.
Yuan> Not really about attachment vs inline. The first patch doesn’t have
Yuan> author, commit message, etc. I’m fine with either attachment or inline
Yuan> :-)
It did, itʼs just that the Author was the From of the email itself,
and the commit message was everything before '---' :-)
Itʼs the style used on linux-kernel and related lists.
Robert
--
next prev parent reply other threads:[~2022-12-21 17:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 17:17 bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Charl P. Botha
2022-12-12 22:28 ` Yuan Fu
2022-12-13 7:48 ` Charl P. Botha
2022-12-13 12:40 ` Eli Zaretskii
2022-12-13 12:03 ` Eli Zaretskii
2022-12-15 9:13 ` Charl P. Botha
2022-12-15 10:41 ` Eli Zaretskii
2022-12-16 1:40 ` Yuan Fu
2022-12-16 5:58 ` Charl P. Botha
2022-12-16 14:11 ` Robert Pluim
2022-12-16 17:52 ` Charl P. Botha
2022-12-21 4:48 ` Yuan Fu
2022-12-21 10:15 ` Charl P. Botha
2022-12-21 17:25 ` Robert Pluim [this message]
2022-12-22 8:10 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k02kllcp.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=59945-done@debbugs.gnu.org \
--cc=59945@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=cpbotha@vxlabs.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.