From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Testing strategy for Tree-sitter modes Date: Sun, 08 Jan 2023 18:27:03 +0100 Message-ID: <87k01x0wew.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14217"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, casouri@gmail.com To: Daniel =?utf-8?Q?Mart=C3=ADn?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 08 18:27:58 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEZSf-0003TL-Nk for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Jan 2023 18:27:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEZRy-0000aJ-If; Sun, 08 Jan 2023 12:27:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEZRw-0000Za-J3 for emacs-devel@gnu.org; Sun, 08 Jan 2023 12:27:12 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEZRu-0002t2-7T for emacs-devel@gnu.org; Sun, 08 Jan 2023 12:27:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1673198826; bh=5dEMMFFrewk91EIoXd5W1tyv57zfqldNvhM2b111dGc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=ciibwYjxYvwvuD5PNosYAMZJExQMxTPxEyRHpBko7hrdqRwpPxbXwPD/iLGRaaDxe fu6S4zrqyWWWPFPaDnhEGwLrfw6kxNrxZmMtXEz3z+9wZRYATC7KnfJqhqpwg/xDNt asObE9Dl7kLB28K3zsLkC7cz2t1jR9SlA6R0PyrweuDpksOffqhzWHe5WEpSigM3XY PrPtItq47bHlIsjSBGNYoY/9Uxy84T61unBmM5NqX2fwcE+q2nXdErTFuAA+Ov4yQI 7kpRJxEdWNMDaXVe+esUIrrE1biVWwqjHu8rOfdOo1aQo/az3aOvIM7RsoAbR6nxIK iDxvd+H5V8GFg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.37.45]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MVvPJ-1pOddn0G8r-00Rlwf; Sun, 08 Jan 2023 18:27:06 +0100 In-Reply-To: ("Daniel =?utf-8?Q?Mart=C3=ADn=22's?= message of "Sun, 08 Jan 2023 15:23:57 +0100") X-Provags-ID: V03:K1:tLMiIN5uVhULYZPq2DhMa23KKNi4tijr4BSt8E62zeM76SOm+XV IhW9gHkff5Pxq2n7WsVXgbsK6wTrFr18kGnKQY3p2nfuC1ys8AuqilPMH2CaIWi1AYRUwqE zaR2B/iMECzuKTiKJRfdXg/Bajk4mtyF/6CnWMWWI178/2DqdJxwSS6y71gLb5Le0CxjsIG 9FksPt55MSaOc8evOr00Q== UI-OutboundReport: notjunk:1;M01:P0:XVDpfDBG6n8=;jt1fDXKiUf8zXluNP1tkGBKraDw XPokFeelvrKVOdTicvf1Axb/V4aLmlgsGIZyoeQ1giZ2AD84mOgG6jMlsgZ0uR2bXeWUnQ0E6 gIzKL/lUCXHSEIwzeJyzqKtxv+ivAmrZHWezRYPC3UmKV7LF8nW56CHsGFxqPtjaWMNpwNTUq JTgmK8s/+x6yNGTTknnN0tNH7QXwMG0T5LxTi5zqYIdQR0eSx5qvlOh5o0LWKBDY8cNPEPFAJ g12iazwMACtIgV+B5bqPTV0IvUnfzkZrI/BYtQLlXPXNqCb0FQS/xfLPL2VQfM5LEnHG+BgQX qWPdonfdM5692tjeruLAWYD7LYy1SAYjHBAlZqjubXU0Qvzo4GaSCFCF2Ui1RwXXLeD8io2gD 3TuOPV2dISIveTudHUE1fd+A7db6RmL+f4VpRnCxS7rxnV3VOHRjzjzCSVTmMHQRB5QCNqP6n SdtY+CdWDLaOnbVhEb8IbBhjflAamBUpGy57Tg/x1O1sHX2CxRugAh1nBCwgjlG5tmoaQqeo1 28JohaCKtAhFceJQ6JfXtmQYUWcDluZ4vrQIF6DDKd8jKf5PqR/00o7VuUFaG/RpoZdnSS2O3 HBdzN1Nw59gTax1nnw+TQwK+6ycsnxtYu6r4Yzd5CK2eMTpAbzZgSx5NXHy1DwFm/R2PbNqbM +pBL3Lqkon/nwx1ImzrLX7iXIt2Fy5+XwKsnxFB2DMLl4DLc4hHI/lILXkjx9LS10uT1RBZ78 rkI4+AyhFSAwPpTgbszUsVkQe5zw+uIRjPLCio/jG+zxoaSGNOoBKfePi5ylwWVU9e/ujwCf Received-SPF: pass client-ip=212.227.17.21; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302291 Archived-At: Daniel Mart=C3=ADn writes: Hi Daniel, > The tests are skipped if the Emacs build does not have Tree-sitter > enabled, or if the corresponding grammar is not installed. Perhaps it > would be a good idea to install these Tree-sitter dependencies in the > container images used for EMBA (https://emba.gnu.org/emacs), so that > we're able to run Tree-sitter tests in continuous integration, and even > play with different versions of Tree-sitter or the Tree-sitter grammars > to detect incompatibilities. I'll leave this decision to the people in > charge of EMBA. Good idea. See the source tree, file test/infra/Dockerfile.emba. If you could provide an extension for this, adding the Tree-sitter dependencies, we could arrange to bring it to EMBA. (Personally, I don't know what to do wrt Tree-sitter) > Thanks. Best regards, Michael.