From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument Date: Thu, 19 Jan 2023 11:16:24 +0100 Message-ID: <87k01iakxz.fsf@gmail.com> References: <878ri2gx3r.fsf@daniel-mendler.de> <87r0vtaxtu.fsf@gmail.com> <3d2cc069-d258-f0b6-9679-eb13a1415202@daniel-mendler.de> <87edrsb5o3.fsf@gmail.com> <9d95e891-22ad-d700-3fab-69948a8a1a17@daniel-mendler.de> <87o7qualwa.fsf@gmail.com> <17aa757a-935d-547c-b432-9529d1ed6d6b@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25799"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 60867@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 19 11:24:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIS5y-0006Xh-UZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Jan 2023 11:24:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIRyi-0002eV-QP; Thu, 19 Jan 2023 05:17:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIRyh-0002W1-2I for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 05:17:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIRyg-0007XW-QF for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 05:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIRyg-0002zP-Br for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 05:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jan 2023 10:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60867 X-GNU-PR-Package: emacs Original-Received: via spool by 60867-submit@debbugs.gnu.org id=B60867.167412339511448 (code B ref 60867); Thu, 19 Jan 2023 10:17:02 +0000 Original-Received: (at 60867) by debbugs.gnu.org; 19 Jan 2023 10:16:35 +0000 Original-Received: from localhost ([127.0.0.1]:42695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIRyE-0002ya-Mk for submit@debbugs.gnu.org; Thu, 19 Jan 2023 05:16:34 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:52158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIRyC-0002yN-QW for 60867@debbugs.gnu.org; Thu, 19 Jan 2023 05:16:33 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id g10so1110108wmo.1 for <60867@debbugs.gnu.org>; Thu, 19 Jan 2023 02:16:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=sMMZDfHkkzhWMgzWe9JcvwQrjwxvK0yXUXhpOSkAjp4=; b=ovsTtGV7xa98WzYxp/yNTFkiLY9tRxBEPYTGcJtKKgXrJ86o7uiZfK2Gl0ufyH/iPo 7iSjDw5Z/T3OrZKJv6rYkZGft8/syAd9tFJz1ZpTCh6qzdQDXdMFvBLtxZH0JqMDWanD /2iaZp9XWnVleP6xqB8vSnb1OhKZA0xEMvkmp5sifv3dlFAnv+H4p0oyIzUy1hAPD93E dY1WlkmcViYzu9ZevDFPUqJrVnGAQIQQasOyww4Zt3zGv+q64h1uM3GVc0qPb/8zeeCA ZFZk9m9WK2+pt7dxOAFAWSYtpbgcGsJOBMqynTC8Uk3bwEtC8G/RfOpGdQrHaT3AQ8he 5o/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sMMZDfHkkzhWMgzWe9JcvwQrjwxvK0yXUXhpOSkAjp4=; b=Lsxs8HHhR8sTqBoBfGQzGiaL2z859pnOr2nDbEvnhFqq7Kyij7g0Nl9ySto5dg3rJ0 UezzR0VB9srSVQt1XopG9vYi6zonfUpzonc16LQU3aVLrXaIZFabo1+E2vQm7EyGdlKr IVruot8YVoHLjkOG2qtVN9U5Sd6jcN5WWZWn+zGClqffJh++v9+K57Dah89dAbUaq552 i1H2aS34euSCATqX/hw18ITns7FIOU6WikJ3sHAdmF1Yu+VxhbXHKMSYJn3K+c6m3NWG VKw9nDbMPhq+qTlr6sGCNiYyS72V08l5mEa5f945ig9gCPRoVO1LKCkFE1V2wxt9Yip+ n7Xg== X-Gm-Message-State: AFqh2kqBuUpdic9Mu8598Vf3ecg1K+rQYyePd5kiKuvXwdXqcxYl4UK4 KSjOqS5Y+lKcZe3X0DeMu6U= X-Google-Smtp-Source: AMrXdXsn5f61rD9ecc5F1wzNmZXpvl3I81MMRJfZreBWGG25KUyLfqNe0tyZskitO5fE2wOQHi7YYQ== X-Received: by 2002:a05:600c:2116:b0:3d6:10e:68a8 with SMTP id u22-20020a05600c211600b003d6010e68a8mr5825401wml.0.1674123386756; Thu, 19 Jan 2023 02:16:26 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id f2-20020adff982000000b002bde537721dsm15413827wrr.20.2023.01.19.02.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 02:16:25 -0800 (PST) In-Reply-To: <17aa757a-935d-547c-b432-9529d1ed6d6b@daniel-mendler.de> (Daniel Mendler's message of "Thu, 19 Jan 2023 11:08:07 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253693 Archived-At: >>>>> On Thu, 19 Jan 2023 11:08:07 +0100, Daniel Mendler said: Daniel> On 1/19/23 10:55, Robert Pluim wrote: >> And of course the following for consistency for `keymap-lookup' as >> well. I now firmly believe that the new keymap functions should use >> `key-parse' and not `kbd'. Daniel> Robert, speaking of `key-parse', I wonder why this function acc= epts Daniel> invalid key strings. Why don't we move the `key-valid-p' check = to Daniel> `key-parse'? This would alleviate the need for many additional Daniel> `key-valid-p' checks across keymap.el. One could maybe even get= rid of Daniel> the `keymap--check' helper. Do you have an example of such an invalid string? Daniel> The function `key-parse' is publicly exposed to the user and as= such it Daniel> would be good if it were as strict as the rest of the keymap.el= API. Daniel> However `kbd' has been reimplemented based on `key-parse' which= prevents Daniel> `key-parse' from being more strict. One could either introduce a Daniel> `key--parse-lax` function which is used by `kbd' and `key-parse= ' (plus a Daniel> `key-valid-p' check) or add a NOERROR/NOVALIDATE argument to Daniel> `key-parse', which is then used by `kbd'. What do you think? >> Eli, is this too much for emacs-29? Daniel> While it is late for 29, these APIs were newly and I believe it= would be Daniel> better to improve them now, such that they don't have to change= again in Daniel> the next release. I think it=CA=BCs too late to make such changes for emacs-29. I=CA=BCm not = even sure that the minimal changes I proposed will be accepted :-) Robert --=20