From: Robert Pluim <rpluim@gmail.com>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: Eli Zaretskii <eliz@gnu.org>, 60867@debbugs.gnu.org
Subject: bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument
Date: Thu, 19 Jan 2023 11:16:24 +0100 [thread overview]
Message-ID: <87k01iakxz.fsf@gmail.com> (raw)
In-Reply-To: <17aa757a-935d-547c-b432-9529d1ed6d6b@daniel-mendler.de> (Daniel Mendler's message of "Thu, 19 Jan 2023 11:08:07 +0100")
>>>>> On Thu, 19 Jan 2023 11:08:07 +0100, Daniel Mendler <mail@daniel-mendler.de> said:
Daniel> On 1/19/23 10:55, Robert Pluim wrote:
>> And of course the following for consistency for `keymap-lookup' as
>> well. I now firmly believe that the new keymap functions should use
>> `key-parse' and not `kbd'.
Daniel> Robert, speaking of `key-parse', I wonder why this function accepts
Daniel> invalid key strings. Why don't we move the `key-valid-p' check to
Daniel> `key-parse'? This would alleviate the need for many additional
Daniel> `key-valid-p' checks across keymap.el. One could maybe even get rid of
Daniel> the `keymap--check' helper.
Do you have an example of such an invalid string?
Daniel> The function `key-parse' is publicly exposed to the user and as such it
Daniel> would be good if it were as strict as the rest of the keymap.el API.
Daniel> However `kbd' has been reimplemented based on `key-parse' which prevents
Daniel> `key-parse' from being more strict. One could either introduce a
Daniel> `key--parse-lax` function which is used by `kbd' and `key-parse' (plus a
Daniel> `key-valid-p' check) or add a NOERROR/NOVALIDATE argument to
Daniel> `key-parse', which is then used by `kbd'. What do you think?
>> Eli, is this too much for emacs-29?
Daniel> While it is late for 29, these APIs were newly and I believe it would be
Daniel> better to improve them now, such that they don't have to change again in
Daniel> the next release.
I think itʼs too late to make such changes for emacs-29. Iʼm not even
sure that the minimal changes I proposed will be accepted :-)
Robert
--
next prev parent reply other threads:[~2023-01-19 10:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 18:20 bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument Daniel Mendler
2023-01-17 17:13 ` Robert Pluim
2023-01-17 17:18 ` Daniel Mendler
2023-01-18 8:36 ` Robert Pluim
2023-01-18 10:29 ` Daniel Mendler
2023-01-19 9:55 ` Robert Pluim
2023-01-19 10:08 ` Daniel Mendler
2023-01-19 10:16 ` Robert Pluim [this message]
2023-01-19 10:39 ` Daniel Mendler
2023-01-19 11:05 ` Robert Pluim
2023-01-19 11:19 ` Daniel Mendler
2023-01-19 15:27 ` Robert Pluim
2023-01-19 15:38 ` Daniel Mendler
2023-01-19 10:23 ` Eli Zaretskii
2023-01-19 10:40 ` Robert Pluim
2023-01-19 11:27 ` Eli Zaretskii
2023-01-19 15:20 ` Robert Pluim
2023-01-20 16:11 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k01iakxz.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=60867@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.