From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61637: 30.0.50; Fix Eglot tests that need HOME=~USER Date: Sat, 04 Mar 2023 19:35:46 +0000 Message-ID: <87jzzwjoml.fsf@gmail.com> References: <87ilfxv5dg.fsf@tcd.ie> <87h6vgelnn.fsf@tcd.ie> <83leksv6az.fsf@gnu.org> <87bkl972du.fsf@gmail.com> <83a60tarif.fsf@gnu.org> <87v8jg68l0.fsf@gmail.com> <83sfekadlg.fsf@gnu.org> <87jzzw646j.fsf@gmail.com> <87ilfgqvp6.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2725"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 61637@debbugs.gnu.org To: Basil Contovounesios Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 04 20:34:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYXe1-0000VP-OI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Mar 2023 20:34:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYXdt-0002t2-Eu; Sat, 04 Mar 2023 14:34:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYXdq-0002sq-NR for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 14:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYXdq-0002MI-AF for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 14:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYXdp-00028E-Vw for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 14:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2023 19:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61637-submit@debbugs.gnu.org id=B61637.16779584388185 (code B ref 61637); Sat, 04 Mar 2023 19:34:01 +0000 Original-Received: (at 61637) by debbugs.gnu.org; 4 Mar 2023 19:33:58 +0000 Original-Received: from localhost ([127.0.0.1]:37776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYXdm-00027u-BX for submit@debbugs.gnu.org; Sat, 04 Mar 2023 14:33:58 -0500 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:46819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYXdl-00027g-AN for 61637@debbugs.gnu.org; Sat, 04 Mar 2023 14:33:57 -0500 Original-Received: by mail-wr1-f54.google.com with SMTP id bw19so5209086wrb.13 for <61637@debbugs.gnu.org>; Sat, 04 Mar 2023 11:33:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677958431; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gQRldFofzJlSdl6liiL6I7TUvhE16JTrHDQJIApYA2E=; b=CizUABO76posx8/T6hcHm6eU7HKhHsQdq4LJfkm0qrxtGyUgzPLHqUH39chSq8GX97 4j5AxkJVKmIZgbSEj2pBE68h3baEoh9SLj5WbXVcgKG4/rqD0i0GxhoX28Dy+GWAhnHY yhklIHnrt9WvfuTksSP4rUZ+oYrJpJcX8tN9/TrSmLh2QgK/ac7A1ZpI9rarEgVGd/Hw lgXjxTUj+/GK7E9lNe9OCy+UqS8whmvp6KXKT6/1wVgOM46u2EsTlEdeYGLeygVMpdwv IKOBmBgsZUgImO2pfnAOWU5pjQ/iZ23nR9aeAEv7qajF4vhjSToVJMpMB84KVN9N2PIl P8jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677958431; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gQRldFofzJlSdl6liiL6I7TUvhE16JTrHDQJIApYA2E=; b=PK/arUVS7sAbB6Gm23mgYd/riryGU332IdFKKhOfdal72m+cKa6pTyh4q62vJ/y7l6 0VdQxRWZ71sl6PKb1P6Mit9SNWsseP1t3GAX5FCPjOY6mXjaW6Z8y6LfiHHys/SkbnoF E2PObphP1cb94OrXF3Lkg1/ElsVD5XEaQcmnFregAalHNX5DL1jyY9hxQqhv7l9JIKzr ubFpELqk/Zip/1OLWE5ZavJIHDYWCrsBnAA6fyIAvWoXq6bwxf6fn8Hjlm2porRH+IT/ pqJll5pX/HGAYaKVSvErEDFMQED7902i6AU4uj4NqWPdThUqq/AMZ1qXpHz1TnmLzxOz 9Ztw== X-Gm-Message-State: AO0yUKVtZ0QVq82Y7DHoiRNm6Y0aUvGCHcb8XlLlNlAiHf8wcBx9FLk0 vSKRTvmVZJ4NNoSQr5ZflLWwmETBT9k= X-Google-Smtp-Source: AK7set8Jpkcg9QC+YSugIbvDLrEspcM72ialu7p9Pab0+UEJDtJmaOBoXa/adbSoEHRzsnkq+e6xkg== X-Received: by 2002:a5d:5447:0:b0:2c7:a55:bef2 with SMTP id w7-20020a5d5447000000b002c70a55bef2mr3243879wrv.46.1677958431238; Sat, 04 Mar 2023 11:33:51 -0800 (PST) Original-Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id s11-20020a5d510b000000b002c55b0e6ef1sm5960919wrt.4.2023.03.04.11.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Mar 2023 11:33:50 -0800 (PST) In-Reply-To: <87ilfgqvp6.fsf@tcd.ie> (Basil Contovounesios's message of "Sat, 04 Mar 2023 17:21:09 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257306 Archived-At: Basil Contovounesios writes: > Based on the test failures I've been seeing for months and tried to > address in the original patches (not all of which are due to an > unexpected HOME setting), it feels like that's probably too optimistic a > conclusion in the general case. If you have described those somewhere, I haven't had a chance to look, but I'm interested. Anyway, the other changes of your original patch are fine. You can just push them if they make tests more robust. > A lot of the relevant tooling places its configuration directly under > HOME for example, not under XDG_CONFIG_HOME. As far as I recall, the only LSP server that relied significantly on user-wide configuration is pyls, and it was fixed via XDG_CONFIG_HOME. When that change made it in (in the old Github repo), this was the commit message: Close #441: shield tests from some user customizations =20=20=20=20 Users' customization of Python indenting style in the standard XDG_CONFIG_HOME location of ~/.config/pycodestyle could cause spurious test failures. We prevent this and similar problems by overriding that environment variable in tests. If this turns out to hurt other language servers used in the test suite, we'll have to revisit. See https://github.com/joaotavora/eglot/issues/441 for more. I can't recall other servers -- used in eglot-tests.el -- that suffer from the same effect (at least to the point of that effect being relevant). > I can also imagine user-specific settings affecting some of the > auto-formatting functionality tested in eglot-tests.el. Yes, but as I said these things are much more commonly set per-project (via eglot-workspace-configuration) or on server invocation (via :initializationOptions) than in a user HOME directory. Makes sense, no? Every project has its practices, etc. Jo=C3=A3o