From: "Matúš Goljer" <matus.goljer@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62256@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#62256: 28.2; Invalid edebug spec gv-define-simple-setter
Date: Sun, 26 Mar 2023 13:28:06 +0200 [thread overview]
Message-ID: <87jzz3da61.fsf@gmail.com> (raw)
In-Reply-To: <83wn36c7st.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 335 bytes --]
> Feel free to submit patches for additional specs as well.
>
> Thanks.
I was thinking about the form in `(get 'compiler-macro
'edebug-declaration-spec)` but actually that one is correct. It's a bit
confusing that top level is always wrapped in () even though that list
wrapper is ignored.
So in the end there's only this one fix.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Fix edebug spec for gv-define-simple-setter --]
[-- Type: text/x-diff, Size: 950 bytes --]
From f99a7d4423008768d7f0a333fb72fc9cabf446ea Mon Sep 17 00:00:00 2001
From: Matus Goljer <matus.goljer@gmail.com>
Date: Sun, 26 Mar 2023 13:20:19 +0200
Subject: [PATCH] Fix edebug spec for gv-define-simple-setter
---
lisp/emacs-lisp/gv.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/gv.el b/lisp/emacs-lisp/gv.el
index dad91e92a45..ac001af06bd 100644
--- a/lisp/emacs-lisp/gv.el
+++ b/lisp/emacs-lisp/gv.el
@@ -271,7 +271,7 @@ instead the assignment is turned into something equivalent to
(SETTER ARGS... temp)
temp)
so as to preserve the semantics of `setf'."
- (declare (debug (sexp (&or symbolp lambda-expr) &optional sexp)))
+ (declare (debug (sexp [&or symbolp lambda-expr] &optional sexp)))
(when (eq 'lambda (car-safe setter))
(message "Use `gv-define-setter' or name %s's setter function" name))
`(gv-define-setter ,name (val &rest args)
--
2.34.1
[-- Attachment #1.3: Type: text/plain, Size: 40 bytes --]
--
Best regards,
Matúš Goljer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]
next prev parent reply other threads:[~2023-03-26 11:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 13:25 bug#62256: 28.2; Invalid edebug spec gv-define-simple-setter Matúš Goljer
2023-03-18 13:36 ` Matúš Goljer
2023-03-23 8:13 ` Eli Zaretskii
2023-03-23 18:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-23 18:11 ` Matus Goljer
2023-03-24 18:40 ` Eli Zaretskii
2023-03-26 11:28 ` Matúš Goljer [this message]
2023-03-26 11:40 ` Eli Zaretskii
2023-03-26 13:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzz3da61.fsf@gmail.com \
--to=matus.goljer@gmail.com \
--cc=62256@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.