From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#62459: [PATCH] Have Xref inherit input method when reading identifiers Date: Sun, 26 Mar 2023 11:57:25 +0000 Message-ID: <87jzz33eu2.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36939"; mail-complaints-to="usenet@ciao.gmane.io" To: 62459@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 26 13:59:00 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgP1Y-0009Mp-6B for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Mar 2023 13:59:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgP0g-00011U-HF; Sun, 26 Mar 2023 07:58:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgP0d-0000vG-E4 for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 07:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgP0d-0000DK-3c for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 07:58:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgP0c-0006g2-D2 for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 07:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62459 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167983185625615 (code B ref -1); Sun, 26 Mar 2023 11:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Mar 2023 11:57:36 +0000 Original-Received: from localhost ([127.0.0.1]:44181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgP0B-0006f5-RF for submit@debbugs.gnu.org; Sun, 26 Mar 2023 07:57:36 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgP09-0006ev-Ad for submit@debbugs.gnu.org; Sun, 26 Mar 2023 07:57:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgP08-0000Cf-Ne for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 07:57:33 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgP06-0008Pq-Tt for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 07:57:32 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C06ED240102 for ; Sun, 26 Mar 2023 13:57:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679831848; bh=b5ny226LNf3611FGcmQzJt7Prw2yHVFrMAw7LMc4AYw=; h=From:To:Subject:Autocrypt:Date:From; b=GTRlELNHfCjO7QndIv2I4tX4eendBgEbLvxNQe1MBv8PSZ3t/2VCtdIsa7i0eKuhb 0PhLxBElM6oGNTil5q7mT7RVn+ahNi0JZk/x12kuVwYtvA+6h1gH+F/aPq6/iJdA3I mLQ8KB7wyxnzcuBmcitZZIAZf12fjykazVoKN88psUi5VZKejBYFi3dvNqIQy/woUO ps9lHu+sNVlttc2WQm7Rjq3r8FLsYRSlcjDqkYI4ANts6lLC+U0T8FCTei3It8xzK0 iDpgtG+aL1OfaQlyiHHTrVNAEdK7+uULjtgVXgR4LL7u7aAuKrsML73QvuYqDhnajC XocvJ4um8YOsw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PkvZb494vz6tnX for ; Sun, 26 Mar 2023 13:57:27 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258671 Archived-At: --=-=-= Content-Type: text/plain Certain languages rely heavily on input methods (two examples I have encountered are APL and Agda), and the default behaviour of Xref when prompting an identifier can be annoying since the user is required to manually enable the input method, if they want to look up an identifier that contains "non-ASCII" characters. For that reason I think it should be OK to set the INHERIT-INPUT-METHOD argument when calling `completing-read'. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Have-Xref-inherit-input-method-when-reading-identi.patch Content-Description: [PATCH] Have Xref inherit input method when reading identifiers >From f640cdc2e4762d8830e860455917e6c2e21e2b4d Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 26 Mar 2023 13:50:27 +0200 Subject: [PATCH] Have Xref inherit input method when reading identifiers * lisp/progmodes/xref.el (xref--read-identifier): Set INHERIT-INPUT-METHOD flag to non-nil. --- lisp/progmodes/xref.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 1ae60796601..d77024136d0 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -1525,7 +1525,7 @@ xref--read-identifier prompt)) (xref-backend-identifier-completion-table backend) nil nil nil - 'xref--read-identifier-history def))) + 'xref--read-identifier-history def t))) (if (equal id "") (or def (user-error "There is no default identifier")) id))) -- 2.30.2 --=-=-= Content-Type: text/plain -- Philip Kaludercic --=-=-=--