From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62707: 30.0.50; [PATCH] Non toolkit scroll bar handle Date: Fri, 07 Apr 2023 13:56:44 +0200 Message-ID: <87jzyndhxf.fsf@ledu-giraud.fr> References: <87h6tsfavd.fsf@ledu-giraud.fr> <83cz4gp3ps.fsf@gnu.org> <87pm8gdt3q.fsf@ledu-giraud.fr> <83a5zkoua9.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25374"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62707@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 07 13:57:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkkiW-0006MQ-Kx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Apr 2023 13:57:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkkiG-00073M-JE; Fri, 07 Apr 2023 07:57:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkkiE-000730-Iy for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 07:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkkiE-0004al-BB for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 07:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkkiD-0004mK-Vt for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 07:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Apr 2023 11:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62707 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62707-submit@debbugs.gnu.org id=B62707.168086861018344 (code B ref 62707); Fri, 07 Apr 2023 11:57:01 +0000 Original-Received: (at 62707) by debbugs.gnu.org; 7 Apr 2023 11:56:50 +0000 Original-Received: from localhost ([127.0.0.1]:55874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkki1-0004lo-Lo for submit@debbugs.gnu.org; Fri, 07 Apr 2023 07:56:49 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:28838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkkhz-0004le-IG for 62707@debbugs.gnu.org; Fri, 07 Apr 2023 07:56:48 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=Kr4XdWBV g3W7mCd1kb3Xw3y4nMih6jZTCivih10LueM=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=yXhaZMK3uhS/EAwKmmXv5C/JYoag4p x8ayymunzGZCzAfPCBQVo+mSkoz+ntAuCtUfNBLX4WgTawgtcwa7t3Bw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=Kr4XdWBVg3W7mCd1 kb3Xw3y4nMih6jZTCivih10LueM=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=gA0Tzbatvg60F/f92KNbFb+up9kc3I8MEl1bqo Dc4Rh6RtbGycwIlJNgVzhEgS/RjwYbvZ8n6HxjlqU2NXNO/CvUjMkgg0ISW0qTe8pfi0fJ dN0CdlVWNV6CdmDw0a+vcF139D4lFGo49xLQW0S4MiqdjxHxVuDvnnZ8EgTpVZcWhZMrS/ iC7mZzD13CKWtrvHgLaauOySZa8SsiJvnvn4wGIAKuT0rAYgtkME/ea/f226mc5eSCe6+W 5ySydmHZlZ8EXLXtwpxhXGN6IaJu4mKWWmmiXH2IYhZ5IiRk1C7hQZaK2NS/uhAm2hCljt yePddUCwmRp6d8XjFolDAS7g== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id e2127992 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 7 Apr 2023 13:56:46 +0200 (CEST) In-Reply-To: <83a5zkoua9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 07 Apr 2023 13:34:22 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259401 Archived-At: Eli Zaretskii writes: > Maybe it's distracting at times, but this is how Emacs behaves with > all the toolkits, or at least most of them. The size of the > scroll-bar thumb is set according to the size of text, not according > to the number of lines. So I don't think we should change this for > just one configuration. Ah ok. Now that I know the meaning I guess it is a feature ;-) I have just checked and it is really less obvious (or distracting) with the gtk3 backend. I don't know why. For my patch, it shouldn't change any behaviour. It is just: - less code in xterm.c - one less call to XFillRectangle But maybe there are some X11 optimization that I'm aware of: like it is better to do two small area XFillRectangle than one big one. So it's up to you to decide if it should be applied or just ditched. Thanks. -- Manuel Giraud