From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 361c5fc2d8e 3/3: Support more predicates in tree-sitter search functions Date: Fri, 14 Apr 2023 12:31:49 +0800 Message-ID: <87jzyfjd8q.fsf@yahoo.com> References: <168142374534.3804.10641447592850495150@vcs2.savannah.gnu.org> <20230413220905.E3C7BC13A84@vcs2.savannah.gnu.org> <87o7nrjq0k.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17832"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 14 06:33:03 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnB7P-0004XM-Mb for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Apr 2023 06:33:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnB6T-00015P-L0; Fri, 14 Apr 2023 00:32:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnB6S-00015G-FC for emacs-devel@gnu.org; Fri, 14 Apr 2023 00:32:04 -0400 Original-Received: from sonic309-22.consmr.mail.ne1.yahoo.com ([66.163.184.148]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnB6P-00060C-7N for emacs-devel@gnu.org; Fri, 14 Apr 2023 00:32:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681446718; bh=9ZtlXY8W5rnhTnhFEy/1UQkeXmZwBWwpapQKXEfanvA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=HGuR1e3xj1iKWP6dPIotWiUsRg978RmVhQmf71YC0rBgWZfztOjDBGVOx3uAxQZXkTo1KWQN0nLNHPQ45FoEb4jKpKK/aisNDTLgZalU5Ja1XybuYgrIUkxMHP7nsglMfzIA7tyCoZvCQZeZtcEs8nSYU5ZgOaKtb9C7tgEkuDC1DonEluks26t3APQ1skPODFLk+SUhEYV+vTmalB7PIAxUcYJRF1L/olpws4kX+rnD12HUeNXHH68gbso8sw1ny3djdCPLp1HLIMKMEijmCagcYxVFXXESG3ceBzA5WjsPCj4jjJ5gz7JU1gtSGi0CgFlTBbgkb8HncXisjw67GQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681446718; bh=D14yzliYSLFdnjHGKdA3tfPEigGyfL2wpHPHn+0ccLQ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=bR1UhIR40j+YjQuFXLaORI18HLWFcTNAiju5k9hQaSxHw0yXBurKKUcrEBc/oFI/dzPLOLHOVOm3lfcU9+FPBBHMm/dY1zdnQzYxcQzVPoKs5qxHtGjKxI3EUH231jW1pHKHZFpsO9f2pjAhA7fZ9UcQPi5VqGtvWXPIwRiXXJF7nnYjthGLvG0yzeldLZz23XHF8sfqvVos6bpek40kMLPZ613BWlI0N7/YYQnO+bvqt7w5oflWfb+DMTnBJ9Y10SoDTvri+WrH6Ss38hKieV/0VJQV4cPLsZaRKaoSsnods39eVh33bhvoqIM67dNaJujt/ThQbAeEtlGS+FEEfA== X-YMail-OSG: zzca5v4VM1niIxBW9hfSn52KnDk8y2eFbfBWUKt3k4o.Eca4tYC4Xy_3.H07DyX tVF_MKGXUmctJSMHnq1942DLIoqVtEhsd93J0m0lE7wpkgajIX4zmS_jcj6gAVeJAXsQyUDsaTJ7 OofhMSNm3XyhJkbNz9SlQkJxi9WoW3le5Um2oHk3vBs5LYFAv1jC20NSej0f6f3JqPBKP2N6tNde uEEgvo9yqAO5TwJGjQZfV8jTq9dYa6XC_xsEK.kFitIpW1xCEW1jbn.T9Tt_HDTQVo5afZesB.KS nYnihZj6mO6f5A2lJBZ.IukODr.mQ3MFzW.LibkSzLN4luywyf9l5SLlPjLlyVaG9.S4lkETqHn9 YbqQLsKfxyRU81Y2blko_eAwsQo05AR8mW1qk7qmW9Ian4gAKsMdbqFHQOQ6GDkbOGF2Z4fFfeba BfnmiTQ6t551Ne80ZYCZYLtse2NKl0VmkLr0K.AjYJWaqY6b2s_VUH6hJ5I8kdo3yCJQ6mYJ6IRO e9KE5sSx7n6mlb6oEnflFXqZR_GT0lYyUEmQ2oj_xBhrwTUYF.mWgM_y48j.lbBj5JnN_jG5KmJG AAiDkk_RdI_CmSvPhEGCbjvZoH3xZDxsTgMAZUqTJM3.uD5WHCWjVk3t284lfUhuhC8JcQpnzmU6 hEr102qoQQANtjYDcT0tYDd.vsrH7p9CxNkcTxLFCOcfa5srFnXDsSQVhwdlf24f58eV5DKnY1_o sTbk.ahr0yy_2ZL6AB0fHKrzDTHVmOS9fjhjZtQ7SpIxdpT7xaYggz_pCHwy839h5IBPZK8VhMFD csDJYH9wskWWZX5uOzIvealmKyYvJRVFytZt8sDuIy X-Sonic-MF: X-Sonic-ID: 5ef04b81-059c-49af-9d4f-e67edf3164a3 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Fri, 14 Apr 2023 04:31:58 +0000 Original-Received: by hermes--production-sg3-6d6fb994f6-gm72r (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 93e08a3a7edfe90f75904c3d69de264a; Fri, 14 Apr 2023 04:31:53 +0000 (UTC) In-Reply-To: (Yuan Fu's message of "Thu, 13 Apr 2023 18:57:50 -0700") X-Mailer: WebService/1.1.21365 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.148; envelope-from=luangruo@yahoo.com; helo=sonic309-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305302 Archived-At: Yuan Fu writes: > Ok, I can add a recursion limit check. Great, thanks. > Is it really necessary? IMHO having the braces is clearer when the statem= ent has more than one line. We prefer to avoid redundant braces, yes. > I like to always initialize variables. OK, but this wastes cycles. > Either way should be fine. I=E2=80=99ve been using the current style > throughout treesit.c. The compiler cannot perform automatic register allocation on `signal_data' your way.