From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Copy and paste from Emacs 29 to Thunderbird =?utf-8?Q?doesn?= =?utf-8?Q?=E2=80=99t?= work Date: Wed, 03 May 2023 14:54:22 +0800 Message-ID: <87jzxpc3c1.fsf@yahoo.com> References: <496CE33D-C23F-4AB9-B545-608DB9B33C97@gmail.com> <87v8hbcfx1.fsf@yahoo.com> <69c64ad0-3ceb-1ead-1b4f-50725fa0e621@web.de> <87y1m6at3w.fsf@yahoo.com> <42f09837-3d25-e5ca-6203-246fe0e28914@web.de> <87ttwuarep.fsf@yahoo.com> <2474aaa4-cf13-89e0-3aa5-32930e4b4123@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5004"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Pedro Andres Aranda Gutierrez , Gregor Zattler To: Tobias Bading Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 03 08:55:26 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pu6Oc-000167-7q for ged-emacs-devel@m.gmane-mx.org; Wed, 03 May 2023 08:55:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pu6Np-0006Wz-Lg; Wed, 03 May 2023 02:54:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pu6No-0006Wq-Hu for emacs-devel@gnu.org; Wed, 03 May 2023 02:54:36 -0400 Original-Received: from sonic304-20.consmr.mail.ne1.yahoo.com ([66.163.191.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pu6Nl-000144-QO for emacs-devel@gnu.org; Wed, 03 May 2023 02:54:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1683096871; bh=wURV6+0AWOywV9mZn+vy7UNkthud4cjDF0Gc0CIP9GI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=AEfVDgZc14cI6aIpdQS0l2QKtjiWp+m1vLA6SOpzf5gjOjTutgikQzeRAEBuxh30e/EbOXgZHwids4SolwCrXxaZqd3fzPzHVqu22qaMWrNgQu0Y4Pz8KcOsHO9WqDnYhR22QGpUczSzHpqPjbsHdS2r7dCTJqCm4Gq/tHeJ6EUkangyaNO59yhDws/ExHlRvioAzcKpe9hHTsRODCPiomLZiBUqOaiJxGEr899aEAl4LuwbyAJ3YQz50HIgIp2JcwwBpKPz076+UIufzeD63dHj+e0xA/dt4DjC0nwpug4Jm/Xe6CGVT/NgD7LTa3v+mqercdgoA4LpRnhTqqFWIQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1683096871; bh=pP4oOYyhbCCQEoT6oBuHqTA4EY9qPI7JXk6maa5noN6=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=bDbiiOM0bVOyrL39g09Wk/CmtgwN07cVxDZCY6szd+biI4dwbnDTNUO9xKZ6PzAHUzykzl9MubKZS6BotxtW5BMoBkEBll1O3F8H4gv+IhTvv82DxyX9ZJ2zxnEDvpL4J/nyPZTZnr/7OO66aIf0ZJCru/cagcfhtVi8ELnw6Pz5x9EGHUBG6Gzf6k3QAY9BdMugB36HDEw9Gp1ca05gKYl6WS1deQOm6PzhkfIYVcZp8iKjnaPAKHd+08EUVMAreUbY0PdKKHzUnzFbhK1n4lbwfC7rh0NXSPl+L+jHXosNHO2gwjRkxp9UbjlhGkVTsZo/I0gJAAEEhtFcGVGLSw== X-YMail-OSG: hU9LAeIVM1nWDlGdgjs1NOzgahUJELiem.XSFpJUE59E5CtLJ5DzprerOSw4g.5 KmyzbyIZ_IyS.R306kdX8.Mrae_dOKdJEYagnRac0PxGfLJWkKRkbak_XIsnrwz798jxZO8HhU4_ ze9BTIlae267tGiQSTeoxP6autIXL3KDq95dUGjKa89Ual1EhaVg3qsInyUq_c8XOhUOXk9LIWN5 ZNL5th1mfOwteuGdaeK4P2jzUKKX5AT3EI5.pyhmgUHVMI7BO3HBukeMteo8db30eDItS4EJBXvh 4zRb_sdS_5WDo47K2P2x69chCAOxACWX24gWzpd6_deq5yU9gjggNTQ8UG6KosrsM.Kd38upauRl LIQqPhujCeg5FYwMofft_.gLCZUWPXm29K8n03R9Kg0KKj1Sb6sw5.JXaqDu0cMyWodGdvWIcID3 Scv22bthfu0wkhn2fjrzOzzpr1z2mUcqtTZz7sozvj7hYX5ASIKOoISGRrGJcxHmdNwUgbeLBnav IPz5dTl8ie.93BbDj3O0FtvDBQ6QErAieEUOuvI2iMkpPYvbL5zocDgSFljn2etnEGVFLsinyjdR SICYI3H0zankgWTCQ.1WZ8L8iGWCk7QeNxUwTA4bSfA99jq2D7vrLUn7HcHAdmjW8nHbZ75pOiD8 .hnQCTjtMCz0t.NYfuyYooJ3SWDKVz7dO3WSoOCEbou.YZzHx.174FPUkzjgPKpgX7w4_Yr.4CFk ee6_iI874oYuMXeBueHO69pDQAcH7vNA24XyCfbzgta4PRY2P8dyy6iNCtC1AaqYAAY5q6ohf.YG qphL3AHmrdmYFHAXy9dpGfXpLECP3Qt.44hCxh3H28 X-Sonic-MF: X-Sonic-ID: 6ee6d246-e6d5-4d95-8611-6a764d982ef3 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Wed, 3 May 2023 06:54:31 +0000 Original-Received: by hermes--production-sg3-6d6fb994f6-f9862 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3589165ced21060ae9375215291041bf; Wed, 03 May 2023 06:54:27 +0000 (UTC) In-Reply-To: <2474aaa4-cf13-89e0-3aa5-32930e4b4123@web.de> (Tobias Bading's message of "Wed, 3 May 2023 08:05:13 +0200") X-Mailer: WebService/1.1.21417 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.146; envelope-from=luangruo@yahoo.com; helo=sonic304-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305766 Archived-At: Tobias Bading writes: > Yes, that works and (trace-function 'xselect-convert-to-text-uri-list) > produces > > 1 -> (xselect-convert-to-text-uri-list CLIPBOARD text/uri-list "nopers") > 1 <- xselect-convert-to-text-uri-list: nil OK, thanks. Eli, is this safe for Emacs 29? 2023-05-03 Po Lu * lisp/select.el (xselect-convert-to-text-uri-list): Don't return any value when converting non-DND selections to this drag-and-drop target. Reported by Tobias Bading . diff --git a/lisp/select.el b/lisp/select.el index 7f089c62dd5..09c678867d0 100644 --- a/lisp/select.el +++ b/lisp/select.el @@ -807,19 +807,24 @@ xselect-convert-to-save-targets (defun xselect-convert-to-username (_selection _type _value) (user-real-login-name)) -(defun xselect-convert-to-text-uri-list (_selection _type value) - (let ((string - (if (stringp value) - (xselect--encode-string 'TEXT - (concat (url-encode-url value) "\n")) - (when (vectorp value) - (with-temp-buffer - (cl-loop for tem across value - do (progn - (insert (url-encode-url tem)) - (insert "\n"))) - (xselect--encode-string 'TEXT (buffer-string))))))) - (cons 'text/uri-list (cdr string)))) +(defun xselect-convert-to-text-uri-list (selection _type value) + ;; While `xselect-uri-list-available-p' ensures that this target + ;; will not be reported in the TARGETS of non-drag-and-drop + ;; selections, Firefox stupidly converts to it anyway. Check that + ;; the conversion request is being made for the correct selection. + (and (eq selection 'XdndSelection) + (let ((string + (if (stringp value) + (xselect--encode-string 'TEXT + (concat (url-encode-url value) "\n")) + (when (vectorp value) + (with-temp-buffer + (cl-loop for tem across value + do (progn + (insert (url-encode-url tem)) + (insert "\n"))) + (xselect--encode-string 'TEXT (buffer-string))))))) + (cons 'text/uri-list (cdr string))))) (defun xselect-convert-to-xm-file (selection _type value) (when (and (stringp value)