From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sun, 16 Jul 2023 20:12:34 +0000 Message-ID: <87jzuz1uq5.fsf@localhost> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <87ttu4gnpt.fsf@localhost> <83bkgb8xo5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14221"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 22:13:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qL87L-0003Vu-Fc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 22:13:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qL876-0004Cp-Fq; Sun, 16 Jul 2023 16:13:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL874-0004CY-Oc for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 16:13:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qL874-0004sy-GB for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 16:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qL874-0003MT-BT for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 16:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168953835512882 (code B ref 64596); Sun, 16 Jul 2023 20:13:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 16 Jul 2023 20:12:35 +0000 Original-Received: from localhost ([127.0.0.1]:48636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL86c-0003Li-TQ for submit@debbugs.gnu.org; Sun, 16 Jul 2023 16:12:35 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:52787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL86Z-0003LQ-HW for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 16:12:33 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 60346240103 for <64596@debbugs.gnu.org>; Sun, 16 Jul 2023 22:12:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689538345; bh=sW3T6KA74iidfobHcIckChVUfHvLqjpWpeGbPxHrZd4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=RDq7RhXp4wzVnmw/TEFcpSNBEcnFmpN4Mz+pMP7KgJUOqdEi9TmCsKFhPG/NHqA8f +gFu2YnKw7/NnpYG1vG5E1RT3aBkVXUk6K5SNrTIhoI5O0ber8lnjGPu7zeAAAm0B+ pxY19h0awc2w+KYkHSaHsQsOa20bTVU2FM9RbFWAvhtlInlSINqSL7Q2g/EVhNZnVT fFhyaX7SIWLM5LSLvGuKQvWi4eAJ/Jwt4EXhWVWm/KF9jh9ICkkdmJxht9PQHr6Coj 7E925nR5r/lbJMKnTWsNWB/KXfJ6o9E/eyjcjexlAVrJXyGj6Uwp6o9vSEMZtDeGkO npz1rnlqetYVw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R3xG043c2z9rxL; Sun, 16 Jul 2023 22:12:24 +0200 (CEST) In-Reply-To: <83bkgb8xo5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265362 Archived-At: Eli Zaretskii writes: >> From: Ihor Radchenko >> Cc: Eli Zaretskii , 64596@debbugs.gnu.org >> Date: Sun, 16 Jul 2023 10:22:38 +0000 >> >> Stefan Monnier writes: >> >> >> . prevent_redisplay_optimizations_p flag of a buffer >> >> . must_be_updated_p flag of a window >> > >> > No idea what these mean. >> > The name `must_be_updated_p` makes it sound to me like it's redundant >> > with the `redisplay` flag above. >> >> I agree about must_be_updated_p. I had exactly same though that it is >> redundant with redisplay flag when reading the code. > > Actually, the must_be_updated_p flag is not for xdisp.c, i.e. not for > redisplay_window and its subroutines. It is for update_window, which > is the last, 3rd, stage of a redisplay cycle, most of the code of > which is in dispnew.c. That's where the newly computed glyph matrix > of a window is compared to its current matrix, and Emacs decides what, > if anything, should be actually written to the glass. What happens > with this flag is that redisplay_window and friends _set_ this flag > for windows that dispnew.c _must_ update. The flag is tested in > dispnew.c, see there for its use and comments. I see. I have to say that these flag names are very disorienting. I have first seen this flag while reading xdisp.c, and it was not obvious at all what it does. The name must_be_updated has no link with glyph matrix terminology, and it is only explained in the commentary in window.h. But then, at the point of reading commentary I was not yet familiar with xdisp... -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at