From: Tassilo Horn <tsdh@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Arash Esbati <arash@gnu.org>,
emacs-devel@gnu.org, Morgan.J.Smith@outlook.com
Subject: Re: master 65108998b1e: docview: imenu: check return value of 'mutool'
Date: Fri, 28 Jul 2023 06:56:30 +0200 [thread overview]
Message-ID: <87jzuktyao.fsf@gnu.org> (raw)
In-Reply-To: <83a5vhkvxq.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> > +(defcustom doc-view-imenu-enabled (executable-find "mutool")
>> > "Whether to generate an imenu outline when \"mutool\" is available."
>> > :type 'boolean
>> > :version "29.1")
>>
>> I'm not familiar with the code, so my apologies if this comment is
>> off, but the change above seems wrong. With this change,
>> `doc-view-imenu-enabled' becomes a string or nil which doesn't match
>> the boolean type. The (and ... t) part wasn't superfluous.
>
> This was okayed by Tassilo, so I'm adding him to this discussion.
Oh, I've not just okayed but actually smuggled in this logical
simplification into Morgan's patch which is obviously not correct in
this specific place. I've just fixed it on master.
Thanks for the heads-up and apologies, especially to Morgan.
Bye,
Tassilo
prev parent reply other threads:[~2023-07-28 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168986904744.4030.15173437427788310246@vcs2.savannah.gnu.org>
[not found] ` <20230720160407.BFFFAC06C66@vcs2.savannah.gnu.org>
2023-07-27 18:49 ` master 65108998b1e: docview: imenu: check return value of 'mutool' Arash Esbati
2023-07-27 19:15 ` Eli Zaretskii
2023-07-28 4:56 ` Tassilo Horn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzuktyao.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=Morgan.J.Smith@outlook.com \
--cc=arash@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.