From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/compat 6a60af22da: Optimize string-search Date: Fri, 11 Aug 2023 06:07:32 +0000 Message-ID: <87jzu2jemz.fsf@posteo.net> References: <169158945793.6388.8459711282582712176@vcs2.savannah.gnu.org> <20230809135738.457BDC038BF@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18692"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Mendler To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 11 08:08:21 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qULJt-0004ex-Jc for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Aug 2023 08:08:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qULJH-0006oo-9r; Fri, 11 Aug 2023 02:07:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qULJF-0006oU-Bl for emacs-devel@gnu.org; Fri, 11 Aug 2023 02:07:41 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qULJC-0005CL-Cn for emacs-devel@gnu.org; Fri, 11 Aug 2023 02:07:41 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EF349240027 for ; Fri, 11 Aug 2023 08:07:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1691734055; bh=/IudG+cHrRsnRdW0PaEtzunxlO89s/qu7GMn7cfPFeo=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=Z0XcfqoNttpPsOs7wU0NuXmqWoOVjpKoVmBREyikbIYqSQZGR+5BmgWM88pvDEphV Cv1HMSCfsmyy4qBLZmRoF0djW3TFkSwv4G5L6LtGmYfXU6sT28ZgxPza/KyFW2KE0/ Ph29f5n4tG11cxsd6Qzmcx8vyyAlJbDsQFwbf84CRwnr6uKs42TjdmqL79BPMralDI Vub+R/Rkw/5+AcRA7jETWpLOVo+/ERf9PVcR4tx0z9hpyzz+gUp7467KNOt/hQKArt cjBHVTDrDKI8srp1/B9jrGULiguRs+nrDJKGxCEHmPws82uKcqNUU9BXeOpW2C4DOI sTu4my3FNWtrA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RMYHB2nfjz6txD; Fri, 11 Aug 2023 08:07:34 +0200 (CEST) In-Reply-To: <20230809135738.457BDC038BF@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Wed, 9 Aug 2023 09:57:38 -0400 (EDT)") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308556 Archived-At: ELPA Syncer writes: > branch: externals/compat > commit 6a60af22da1f1a7b08457a4016b9412a475afe4a > Author: Daniel Mendler > Commit: Daniel Mendler > > Optimize string-search > --- > compat-28.el | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/compat-28.el b/compat-28.el > index fe69315522..b305ab2fff 100644 > --- a/compat-28.el > +++ b/compat-28.el > @@ -52,9 +52,8 @@ issues are inherited." > (when (and start-pos (or (< (length haystack) start-pos) > (< start-pos 0))) > (signal 'args-out-of-range (list start-pos))) > - (save-match-data > - (let ((case-fold-search nil)) > - (string-match (regexp-quote needle) haystack start-pos)))) > + (let (case-fold-search) > + (string-match-p (regexp-quote needle) haystack start-pos))) > > (compat-defun length= (sequence length) ;; [[compat-tests:length=]] > "Returns non-nil if SEQUENCE has a length equal to LENGTH." I don't believe this is a legal optimisation, even if the regular expression is quoted. Consider (progn (string-match (rx (* "a") (group (* "b")) (* "a")) "abba") (match-data)) ; => (0 4 1 3) and (progn (string-match (rx (* "a") (group (* "b")) (* "a")) "abba") (string-search "foo" "foobar") (match-data)) ; => (0 4 1 3) but (progn (string-match (rx (* "a") (group (* "b")) (* "a")) "abba") (let ((case-fold-search nil)) (string-match (regexp-quote "foo") "foobar" 0)) (match-data)) ; => (0 3)