From: Ihor Radchenko <yantar92@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 65896@debbugs.gnu.org, kevin.legouguec@gmail.com, look@strawberrytea.xyz
Subject: bug#65896: 30.0.50; folding text with text properties prevents background from extending past the newline
Date: Fri, 22 Sep 2023 10:12:57 +0000 [thread overview]
Message-ID: <87jzsiy0ra.fsf@localhost> (raw)
In-Reply-To: <83bkdvaio4.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> Are you sure? I am looking at `extend_face_to_end_of_line' and it looks
>> like there is nothing preventing it from accessing it->glyph_row->glyphs
>> array to look backwards into preceding glyphs.
>
> First, glyphs have only partial information about the original face
> properties. IOW, the produced glyph row doesn't have all the info
> that the original text had.
>
> And second, I don't see how the accessibility to the glyphs is
> relevant to the issue at hand. Suppose the visible text of a line is:
>
> aaabbbbxxx
>
> where each letter represents some character with different face -- you
> want Emacs to extend face 'a' after the end of the line, not the face
> 'x', just because the line started with characters whose face was
> 'a'?? that's what the OP said, AFAIU.
I am also not a big fan of using the first glyph/letter in the line.
What about not extending the face unless the last 2 glyphs have eq face
or we have a single glyph in a row?
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-09-22 10:12 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 18:00 bug#65896: 30.0.50; folding text with text properties prevents background from extending past the newline StrawberryTea
2023-09-12 18:51 ` Eli Zaretskii
2023-09-12 20:51 ` Kévin Le Gouguec
2023-09-12 21:35 ` LemonBreezes
2023-09-13 11:54 ` Eli Zaretskii
2023-09-20 12:50 ` Ihor Radchenko
2023-09-21 11:07 ` Eli Zaretskii
2023-09-22 10:12 ` Ihor Radchenko [this message]
2023-09-22 11:56 ` Eli Zaretskii
2023-09-22 12:00 ` Ihor Radchenko
2023-09-22 12:48 ` Eli Zaretskii
2023-09-23 10:51 ` Ihor Radchenko
2023-09-23 11:11 ` Eli Zaretskii
[not found] ` <871qep2l2z.fsf@localhost>
2023-09-23 12:38 ` Eli Zaretskii
2023-09-23 12:59 ` Ihor Radchenko
2023-09-23 13:10 ` Eli Zaretskii
2023-09-23 14:06 ` Ihor Radchenko
2023-09-23 18:33 ` StrawberryTea
2023-09-23 19:05 ` Eli Zaretskii
2023-09-23 19:05 ` StrawberryTea
2023-09-24 5:00 ` Eli Zaretskii
2023-09-24 7:53 ` StrawberryTea
2023-09-24 10:19 ` Ihor Radchenko
2023-09-24 11:59 ` Eli Zaretskii
2023-09-24 18:30 ` StrawberryTea
2023-09-25 4:38 ` Eli Zaretskii
2023-09-26 8:18 ` Ihor Radchenko
2023-09-29 5:47 ` Eli Zaretskii
2024-01-22 14:45 ` Ihor Radchenko
2024-01-23 19:14 ` Kévin Le Gouguec
2024-01-24 16:42 ` Ihor Radchenko
2024-01-25 7:46 ` Kévin Le Gouguec
2024-01-25 13:47 ` Ihor Radchenko
2023-09-21 12:54 ` Eli Zaretskii
2023-09-21 21:07 ` Kévin Le Gouguec
2023-09-22 6:40 ` Juri Linkov
2023-09-22 7:20 ` Eli Zaretskii
2023-09-29 7:12 ` Kévin Le Gouguec
2023-09-29 15:41 ` Juri Linkov
2023-09-29 19:07 ` StrawberryTea
2023-09-30 13:49 ` Eli Zaretskii
2023-09-30 22:55 ` StrawberryTea
2023-10-01 8:42 ` Eli Zaretskii
2023-10-02 4:28 ` StrawberryTea
2023-10-02 6:05 ` Eli Zaretskii
2023-10-05 20:59 ` StrawberryTea
2023-09-13 11:48 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzsiy0ra.fsf@localhost \
--to=yantar92@posteo.net \
--cc=65896@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=kevin.legouguec@gmail.com \
--cc=look@strawberrytea.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.