From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 67794@debbugs.gnu.org, Alan Third <alan@idiocy.org>
Subject: bug#67794: 30.0.50; mouse-face is not respected on SVG images
Date: Tue, 12 Dec 2023 15:07:13 +0100 [thread overview]
Message-ID: <87jzpjo6pa.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <83sf47tumh.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Dec 2023 15:31:34 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
[...]
>> Now a 'C-s foobar' shows the matched string respecting the isearch face
>> even on the SVG image. But when, you move your mouse over the "foobar"
>> string, the SVG image keeps the foreground and background of the default
>> face.
>
> I think we only support colors from 'face' properties on SVG images,
> not from 'mouse-face'. Alan, am I right?
>
> Basically, SVG images specify their own background color, and the
> Emacs display cannot override that, since the image is generated by
> librsvg. So to change the background color, we wrap the SVG in
> another SVG, see svg_load_image. This way, the SVG spec submitted to
> librsvg specifies different colors according to what Emacs wants. And
> we only do that for colors that come from 'face' properties.
This means that when you do a 'C-s foobar' and that the SVG is correctly
displayed with the isearch face (foreground and background), such an
embedded SVG was created on the fly? If so, I think we should do the
same for mouse-face too because this SVG generation is very fast!
>> (note: I have tried to track this down but debugging Emacs display is
>> *hard*. I have read and tried the "Debugging Emacs redisplay problems"
>> section of etc/DEBUG with no luck so far.)
>
> The mouse highlight is implemented in note_mouse_highlight and its
> subroutines. If you already discovered that, then what were the
> difficulties you faced in understanding what happens?
Yes, I used to put a break point on show_mouse_face but then diving down
to x_draw_glyph_string it is hard to "see" what is going on here. As it
was working with face such as isearch, my new strategy was to find out
how it worked here but now I don't know where/how to break to the
correct place.
--
Manuel Giraud
next prev parent reply other threads:[~2023-12-12 14:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 13:12 bug#67794: 30.0.50; mouse-face is not respected on SVG images Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 13:31 ` Eli Zaretskii
2023-12-12 14:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-12-12 14:43 ` Alan Third
2023-12-12 16:35 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 17:28 ` Eli Zaretskii
2023-12-13 8:18 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 12:19 ` Eli Zaretskii
2023-12-13 14:13 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 15:08 ` Eli Zaretskii
2023-12-13 16:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 16:23 ` Eli Zaretskii
2023-12-13 16:50 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 17:29 ` Eli Zaretskii
2023-12-13 17:57 ` Gerd Möllmann
2023-12-13 18:11 ` Eli Zaretskii
2023-12-13 18:24 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 18:46 ` Eli Zaretskii
2023-12-14 9:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 9:23 ` Eli Zaretskii
2023-12-14 9:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 10:05 ` Eli Zaretskii
2023-12-18 11:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 11:42 ` Alan Third
2023-12-18 18:36 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 19:48 ` Alan Third
2023-12-19 12:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 13:03 ` Eli Zaretskii
2023-12-19 13:23 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 13:40 ` Eli Zaretskii
2023-12-19 13:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 14:25 ` Eli Zaretskii
2023-12-19 14:39 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 15:34 ` Eli Zaretskii
2023-12-20 8:47 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-20 13:19 ` Eli Zaretskii
2023-12-20 13:54 ` Alan Third
2023-12-20 13:54 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-20 17:53 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-23 10:22 ` Eli Zaretskii
2023-12-12 14:47 ` Eli Zaretskii
2023-12-12 15:20 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzpjo6pa.fsf@ledu-giraud.fr \
--to=bug-gnu-emacs@gnu.org \
--cc=67794@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.