From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#64202: [PATCH] Gnus: Add back end for Atom feeds (nnatom) Date: Sun, 17 Dec 2023 12:27:12 -0800 Message-ID: <87jzpcr2vz.fsf@ericabrahamsen.net> References: <87v8fhmgvw.fsf@dsemy.com> <8734wcfynr.fsf@dsemy.com> <87wmtnbptm.fsf@dsemy.com> <87zfyj8ojz.fsf@dsemy.com> <87ttohxc56.fsf@dsemy.com> <874jggst37.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35552"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 64202@debbugs.gnu.org Cancel-Lock: sha1:IDFzt4hGe7IUYvvMfnWeXZam1sc= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 17 21:28:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rExkD-00094J-UI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Dec 2023 21:28:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rExk2-0003w2-4x; Sun, 17 Dec 2023 15:28:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rExk1-0003vs-9Z for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 15:28:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rExk0-00033B-P4 for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 15:28:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rExk1-0001DR-O5; Sun, 17 Dec 2023 15:28:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87v8fhmgvw.fsf@dsemy.com> Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 17 Dec 2023 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64202 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17028448544627 (code B ref -1); Sun, 17 Dec 2023 20:28:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Dec 2023 20:27:34 +0000 Original-Received: from localhost ([127.0.0.1]:59062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rExja-0001CZ-FT for submit@debbugs.gnu.org; Sun, 17 Dec 2023 15:27:34 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:47072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rExjZ-0001CI-Hn for submit@debbugs.gnu.org; Sun, 17 Dec 2023 15:27:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rExjS-0003ls-Ms for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 15:27:26 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rExjR-0002xn-6G for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 15:27:26 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rExjM-0007sa-MB for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 21:27:20 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276439 Archived-At: Eric Abrahamsen writes: > On 12/17/23 10:55 AM, Thomas Fitzsimmons wrote: >> Hi Daniel, >> >> Daniel Semyonov writes: >> >>>>>>>> Daniel Semyonov writes: >>> >>> > I'll send a patch with a fix as soon as I can. >>> >>> I've decided to setup a mirror of the Emacs repo for further >>> development, so I've pushed the fix there. >>> >>> It can be found at: https://git.sr.ht/~dsemy/emacs-nnatom. >> >> It works now, thank you. I tested my blog's Atom feed. I also reviewed >> the patch and it looks good to me, other than "checkdoc" reporting that >> `nnatom--read-part' needs a docstring. I think Eric should review it >> too before it goes in. > > I will soon! Thanks for setting up the mirror, that makes things easier. I just took this for a whirl; so far so good! TBH I forget how nnoo.el works if I don't look at it for a couple of weeks, so I don't immediately have any comments there. In general I prefer using structs instead vectors-as-structs, though mostly that's for ease of update and change, and if the article vectors aren't being written to disk as such, maybe it doesn't matter that much. Something to consider, anyway. I'll keep trying to break it. Thanks! Eric