From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68402: [elpa/csv-mode] [PATCH] Add option to turn off the "Region OK?" prompt Date: Fri, 12 Jan 2024 14:52:31 +0100 Message-ID: <87jzoeveu8.fsf@runbox.com> Reply-To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8132"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier To: 68402@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 12 14:53:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOHyU-0001qn-3S for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jan 2024 14:53:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOHyE-0005HP-Vv; Fri, 12 Jan 2024 08:53:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOHy4-0005GH-DS for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 08:53:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOHy4-0000sl-4L for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 08:53:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOHy1-0008E6-Pw for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 08:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jan 2024 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170506757731608 (code B ref -1); Fri, 12 Jan 2024 13:53:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Jan 2024 13:52:57 +0000 Original-Received: from localhost ([127.0.0.1]:35210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOHxw-0008Dj-OS for submit@debbugs.gnu.org; Fri, 12 Jan 2024 08:52:57 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:43968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOHxt-0008DQ-OJ for submit@debbugs.gnu.org; Fri, 12 Jan 2024 08:52:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOHxm-00053M-PQ for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 08:52:47 -0500 Original-Received: from mailtransmit05.runbox.com ([2a0c:5a00:149::26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOHxi-0000iO-Hc for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 08:52:45 -0500 Original-Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1rOHxc-004Fbx-49 for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 14:52:36 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From; bh=rv9WgUBG9mAC7/6VQExpYXbmKvdGvaxLLFDN+G5fw+o=; b=mfMrs4+Jr/4NaGUHtruPuJdvE j8HoQz3o8wapNGpWCZV+Alkbo6IdrVrzacvPW/k73HzGYyJfs0ZWlaGgqR084KPi4ouptoJeeJAGU haelvMQKw2w6+/KQpIT1c/dRhXY6KQ1HY6GVna9MF3lo9KW4/96TgM3PFuasIyYILGEe5mS4kUr0m Fa3Jgbe1ugBzJf54uYTkSFN2Kir7VpfsZmdHjDDQmguzH+xW3AnAgcfY08kcv8staUmFpfIWjZXhq J1NRK+s1rrMZNA4ZCYkmlLVwQSCshMc3Vu7WQi5kc8zwoU7RZ5MpRtp9ktSCLkzcsqvTWJYC9ZAVI jhd9JPstw==; Original-Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1rOHxb-0001zb-GJ; Fri, 12 Jan 2024 14:52:35 +0100 Original-Received: by submission03.runbox with esmtpsa [Authenticated ID (963757)] (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93) id 1rOHxY-00FPk6-DF; Fri, 12 Jan 2024 14:52:32 +0100 Received-SPF: pass client-ip=2a0c:5a00:149::26; envelope-from=simenheg@runbox.com; helo=mailtransmit05.runbox.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278026 Archived-At: --=-=-= Content-Type: text/plain Hi. Attached is a proposed patch adding a new option to turn off the "Region OK?" prompt in interactive csv-mode commands. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-option-to-turn-off-the-Region-OK-prompt.patch >From 359ef9582e0c30c18a7c30086f93d69b35120337 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= Date: Fri, 12 Jan 2024 12:06:20 +0100 Subject: [PATCH] Add option to turn off the "Region OK?" prompt * csv-mode.el (csv-confirm-region): New option to turn off the "Region OK?" prompt in interactive commands. --- csv-mode.el | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/csv-mode.el b/csv-mode.el index 574050aa94..f639dcf59a 100644 --- a/csv-mode.el +++ b/csv-mode.el @@ -4,7 +4,7 @@ ;; Author: "Francis J. Wright" ;; Maintainer: emacs-devel@gnu.org -;; Version: 1.22 +;; Version: 1.23 ;; Package-Requires: ((emacs "27.1") (cl-lib "0.5")) ;; Keywords: convenience @@ -110,6 +110,7 @@ ;; Since 1.21: ;; - New command `csv-insert-column'. ;; - New config var `csv-align-min-width' for `csv-align-mode'. +;; - New option `csv-confirm-region'. ;; Since 1.9: ;; - `csv-align-mode' auto-aligns columns dynamically (on screen). @@ -271,6 +272,10 @@ after separators." "If non-nil, make separators in aligned records invisible." :type 'boolean) +(defcustom csv-confirm-region t + "If non-nil, confirm that region is OK in interactive commands." + :type 'boolean) + (defface csv-separator-face '((t :inherit escape-glyph)) "CSV mode face used to highlight separators.") @@ -557,9 +562,10 @@ The default field when read interactively is the current field." (exchange-point-and-mark) (sit-for 1) (exchange-point-and-mark)) - (or (y-or-n-p "Region OK? ") - (error "Action aborted by user")) - (message nil) ; clear y-or-n-p message + (when csv-confirm-region + (or (y-or-n-p "Region OK? ") + (error "Action aborted by user")) + (message nil)) ; clear y-or-n-p message (list (region-beginning) (region-end)))) ;; Use region set by user: (list (region-beginning) (region-end))))) -- 2.39.2 --=-=-=--