From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#68678: 29.1; package-recompile-all should skip system packages in package-directory-list Date: Wed, 24 Jan 2024 22:17:31 +0000 Message-ID: <87jznyfkas.fsf@posteo.net> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68678@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 24 23:18:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSlZm-0006nQ-5m for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jan 2024 23:18:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSlZI-0006st-0Z; Wed, 24 Jan 2024 17:18:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSlZE-0006sJ-Vg for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 17:17:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSlZE-0007li-Ka for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 17:17:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rSlZK-0000Gi-30 for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 17:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 22:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68678 X-GNU-PR-Package: emacs Original-Received: via spool by 68678-submit@debbugs.gnu.org id=B68678.17061346681010 (code B ref 68678); Wed, 24 Jan 2024 22:18:02 +0000 Original-Received: (at 68678) by debbugs.gnu.org; 24 Jan 2024 22:17:48 +0000 Original-Received: from localhost ([127.0.0.1]:46798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSlZ5-0000GE-Sf for submit@debbugs.gnu.org; Wed, 24 Jan 2024 17:17:48 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:59663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSlZ2-0000Fs-Q9 for 68678@debbugs.gnu.org; Wed, 24 Jan 2024 17:17:46 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D06D4240027 for <68678@debbugs.gnu.org>; Wed, 24 Jan 2024 23:17:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1706134652; bh=Z1ZvSNJtXPpdfK+t5NsNcmU/aTw1jOmhCPQ6f2e0oOY=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=Scqbn6j0E1L61bRmT4n+geuFVxfaUNXsZpbGnml+h6HwJnI5NyDwp5BwUfDvLlwDK BJHjgHAqxo+4k6ChZebBEswVpyrFzr4b3Iuw6ptrhW3Yds2fQFovbnvAl51u7TPdUN wQKLlDLIUQPPZmXUHgjeeqd0CrENskj2ae3WC48SSegBUIs7vHoO6L/M/XUa5T3QxS xzlIqp2SCpHz1sskvKduxIHb8ORpo/J0edhuBiODJUzndYznMcC2hWRx2snJ6ZtpBy Au+hVsY/JRp7jlC9K8KD3p+WlzzqATMSe4N3JkyT+TxZDu9UF5icdX02NQdTrkb0GH NN5LVTYQAIHew== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TKyxm1K0Qz9rxD; Wed, 24 Jan 2024 23:17:32 +0100 (CET) In-Reply-To: (Allen Li's message of "Tue, 23 Jan 2024 15:48:35 -0800") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278823 Archived-At: --=-=-= Content-Type: text/plain Allen Li writes: > package-recompile-all currently attempts to recompile all packages, > including the system packages listed in package-directory-list. > > System packages are generally byte compiled as part of installation, and > are not writeable by normal users. > > package-recompile-all attempts to recompile these, which will almost > certainly error out due to this. > > It would be better if package-recompile-all only tries user installed > packages (in package-user-dir), which are more likely to need > recompilation. Perhaps as a prefix arg option? Would this patch resolve the issue for you: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 868373f46c2..fe7b10f569a 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2610,7 +2610,8 @@ package-recompile-all are invalid due to changed byte-code, macros or the like." (interactive) (pcase-dolist (`(_ ,pkg-desc) package-alist) - (package-recompile pkg-desc))) + (with-demoted-errors "Error while recompiling: %S" + (package-recompile pkg-desc)))) ;;;###autoload (defun package-autoremove () --=-=-= Content-Type: text/plain > In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, > cairo version 1.16.0) of 2023-09-03, modified by Debian built on > kokoro-ubuntu > System Description: Debian GNU/Linux rodete --=-=-=--