From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#67220: 30.0.50; ERC 5.6: Prefer parameter-driven MODE processing in ERC Date: Thu, 25 Jan 2024 13:45:33 -0800 Message-ID: <87jznx6q9u.fsf__47635.2070619882$1706219173$gmane$org@neverwas.me> References: <87pm0aphr2.fsf@neverwas.me> <87mst2unhi.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5487"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 67220@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 25 22:46:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rT7Xx-0001Bu-5a for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jan 2024 22:46:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rT7Xr-0000CP-Fj; Thu, 25 Jan 2024 16:45:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rT7Xo-0000C5-9U for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 16:45:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rT7Xo-0003vZ-1V for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 16:45:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rT7Xu-0002GN-2i for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 16:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2024 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67220 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67220-submit@debbugs.gnu.org id=B67220.17062191508678 (code B ref 67220); Thu, 25 Jan 2024 21:46:02 +0000 Original-Received: (at 67220) by debbugs.gnu.org; 25 Jan 2024 21:45:50 +0000 Original-Received: from localhost ([127.0.0.1]:49382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT7Xh-0002Ft-MH for submit@debbugs.gnu.org; Thu, 25 Jan 2024 16:45:50 -0500 Original-Received: from mail-108-mta79.mxroute.com ([136.175.108.79]:38057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rT7Xf-0002Fk-KJ for 67220@debbugs.gnu.org; Thu, 25 Jan 2024 16:45:48 -0500 Original-Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta79.mxroute.com (ZoneMTA) with ESMTPSA id 18d4295e8fc0003727.001 for <67220@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 25 Jan 2024 21:45:37 +0000 X-Zone-Loop: 5c99bb8d7c688bd8e2573b95d25aec1ee853d7d83cc0 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Pwelz1az8uqcKsav5aAgJTewsWffe4NGyTDZ2nJIKWU=; b=Xv5V4/EkJXtD71wQy7tDBuExSI VxNAeme8DevLwSFmrdUe+KKGi8o6i1KeJ+MGVKmGufDPLq7wsvd9w1uLbKkpEv+B8DTARGmCQOVOa 873DQM1PktRxjts4v7+JluJZoT8Q0quvnnYWYeHd1biMp/qK11miR3c4VmuXfcwrxcKiYDrQTvJtt NFoFrW4BA8yRkajpvU5pl552ATRCtBez5dqEJ9gb2Brw8WQslxJjyYCGZY7wMJNr06oQCuhl7HoeK tOGX0RSLWMphpomD1mCM+PWbO78ntSSXyFIvHahm0SwOG4X1Yk4mWv0qJV20CTCcEmovPQNRV1U17 Js0JaEmw==; In-Reply-To: <87mst2unhi.fsf@neverwas.me> (J. P.'s message of "Thu, 18 Jan 2024 17:21:29 -0800") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278869 Archived-At: "J.P." writes: > "J.P." writes: > >> Tags: patch >> >> In the early days of IRC, parsing a "MODE" command from the server was >> comparatively straightforward. There were a few well known letters, some >> taking a single argument, and a standard set of status prefixes. But >> somewhere along the line, things got more complicated, and it seems ERC >> never got the memo. While it may appear obvious that sticking to a >> hard-coded, heuristics based approach doesn't really accommodate ERC's >> core tenet of extensibility, the risk of shifting toward something more >> parameter driven was probably never justifiable without a vocal demand. > > In the initial set of changes, I only partially implemented PREFIX-aware > channel-membership handling (here and in bug#67677, for the formatting > side). The main reason for this omission was that I mistakenly assumed > the lack of a valid use case for doing so. However, a latent clue in our > own test suite attesting to the contrary was staring me in the face the > whole time (until I unceremoniously erased it [1]). Since then, I've > come around on this and now think we might as well see it through the > somewhat arduous last mile. See attached. > > Thanks. > > [1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4939f413 > ^ Grep for "Yqaohv". The mentioned changes have been installed as: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=aedc8b55 This bug is already closed.