From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 1ef8b90ae06: Simplify imenu setup for {cmake, dockerfile}-ts-modes Date: Sun, 28 Jan 2024 13:21:23 +0800 Message-ID: <87jznuhw30.fsf@yahoo.com> References: <170633049046.30614.86278647904102476@vcs2.savannah.gnu.org> <20240127044130.C6F37C4068B@vcs2.savannah.gnu.org> <868r4b9qjs.fsf@gnu.org> <875xzfkxq7.fsf@yahoo.com> <87fryijl60.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org, dev@rjt.dev To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 28 06:22:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTxcd-0004we-JY for ged-emacs-devel@m.gmane-mx.org; Sun, 28 Jan 2024 06:22:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTxby-0007Ou-RQ; Sun, 28 Jan 2024 00:21:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTxbw-0007OX-KU for emacs-devel@gnu.org; Sun, 28 Jan 2024 00:21:40 -0500 Original-Received: from sonic301-30.consmr.mail.ne1.yahoo.com ([66.163.184.199]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTxbv-0002YD-2Q for emacs-devel@gnu.org; Sun, 28 Jan 2024 00:21:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706419296; bh=vKU4n1K76JkhMGh/Jvz2Hj6iGNmGlsc3kaiWS3fKJa0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=IDSlV4Bl6+Ef9JglvP7WU6I2vZBOW5LGpoDJvK593gKi8GLvz0j/m4n5b98EjZqRITjznhm3yCo1YvfDW9WYyFCvK8CH5SgFmpEiZYz4SzPJ8gqjY/d4YxWyZjenU9E0shTOyYBxrJpq4/wXtRxFuXm2wWPnnE/JgMOnweeu8Fg1LvPaJFuEY9OhQ++pQ0Bpyio9UUO7Lq1cSSqgDqy/I1ruXuhxbFJ/1RrkEuBxomJ0qvfl31Slu7WGQVTzdFsfVmb0fkcBeHO5fUXNqUs6w9fygTE7gDGLZv4/skM3I7AJmwPQ6jGan6hem51QcqsMDG/SOR/f9DVNB+7jJAjhzQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1706419296; bh=W/xdWsIvVBrS5nuB3T8wcxa0+zd/GgsIQtkreVeK84e=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XOusgf0wcKufmOr4vQvE7eWiRU8a5cZktxYEXl1B01lO4N7n4wGikHpl/TSZVdDIuLIOTZZfHnGeVACj6odnb/K+cchjQLDKmSFEKUCjQQt+rQNeWvR+F3qp2JMhcc5i5l/2nW9/Xb8IRcR+/JdjZ5pGZgWgZfMb7tO+yBq7a1A3kEDd0KBiF3Z2vGmnFem6tgTvM/QUQK+w4aeKQJ4bdpWjDPhfp0Cu5ON7XGyP06VtDEe1ukUk4y6WJKWELeWCdlZgOBfnR/pTWwmrsO7yipPkA4e7DRsy251xozG9vZrr7dcyDkhq3RxxrDT7py0pELadw1ZHz7I35FKBT4et5A== X-YMail-OSG: Ut9ZfagVM1n_lJH2SbEUftW8AgNZLc95D_sxjkcfPOohHDZumCkUwNLEoq6Htlt 8KmlSTFqBFi.4RJvUYMeR_Am4yF_0XBakg2guOarwyU5p6nvn0udFWLGiLNAq49aVzOvaEl.2yLU UKmr4TmxQhBjsOUxyJ9sWJ1xxoYjsZkGLNW92tG8.3OSHJyxzS72Lf84bkayEQJf7Ja8eM0CDLGc y.WyFYT2TGXJEoWGCAqkxFCtbQlmd_vtuBEV9pxsQRYXkHaqXGcy7BWbBSpYV5t.fNCHw40lyBPP u3lQdOxdAlbeQu6S3DI7JeBzczU5jR3._gQoMiKs8pj_ZC57okW9OPEavtA.qyXpQLhiNz9Bi5p. Rb_iZGvRjTWDiiTm5EVqdRKhK6t7SzCEcmG.VZyK8AzJCLEMYRI5jyOJ5HmJwf2AoA9yGmBi6udt RYOFCwTZrf0GIdrCV_0LZEYth87q4quWfcCYE6TSifZH6Hez9ARfJy_EkITmxui5zH7y9uiz3w40 mwoXHyoEa2SMVjoGpX04sPb1HYB8_bVXfgXnT8yUH9AjcL4uFNbU7.KeZJdfTkgGBzlp.0Tynx5x BnaIHeHgerjZxS.rOWJt3bF7T4JvEcDIJUQ24wd_5.nWnPQmDyPTptYCbyZ0FgbRCTBAg_IJVZzc N_FuBI1EodjeeKqcixJB2LrhnzmdCwV.4HxEKctJ1b4uunp5cR9uiRCr1BCX3IN7TT34AmZCy9ly dJaLi8UnR2qWA2bFGLBJRpZ8fTTCpFbNvfpYI4pe7ccBprH0cXbzpHgaBOS3q7HRn6uY9aRdw7go SL85PCcN0lABYpIRdzrQaI6X5NpiGzYhjLeTgAtpuc X-Sonic-MF: X-Sonic-ID: 32499efe-df53-44b6-a9ac-25a2d2c3aa4a Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Sun, 28 Jan 2024 05:21:36 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-8hvwv (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID fb0d82c1e64426d4bfe3be07613fd8f7; Sun, 28 Jan 2024 05:21:32 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Sat, 27 Jan 2024 19:00:34 -0800") X-Mailer: WebService/1.1.22046 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.199; envelope-from=luangruo@yahoo.com; helo=sonic301-30.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315524 Archived-At: Stefan Kangas writes: > ? They are not affected by this change though? Are we looking at the > same patch (commit 1ef8b90a)? > > Which areas of Emacs do you think are affected? AFAICT, nothing risks > breaking outside of the changed modes. For example, autoloading is not > affected (`declare-function' only affects byte-compilation). You are correct as to autoloads, but it certainly affects imenu. > Did you read Bug#68706? Yuan decided to install it as a bugfix on > emacs-29. > > The question is if this change is different from the many other bug > fixes that we routinely install without much justification. This is why > I'm asking for something more specific. Yes I did: it's larger, and encompasses much more than only the fix. Yuan's precise wording was: > Thanks Randy, pushed to emacs-29 since it includes a fix. which does not suggest that the safety of the patch in whole was a factor in his decision, but only the fact that a bugfix was one component of the patch. This prompted my reply that the inclusion of a bugfix is not the sole criterion we expect changes to the release branch to satisfy, and I trust we are in agreement in this respect. > I don't know which changes this is in reference to, but I know that you > often work on things like X support, that carries with it a bigger risk > for breakage (as it's more complex), and it affects more users to boot. > It is natural to be more careful with changes in core functionality than > in specific modes. > > Note also that we have been decided to be more lax when it comes to the > treesitter stuff, seeing as its new in Emacs 29. No disagreements there, but "the treesitter stuff" doesn't extend to imenu setup code in major modes which happen to make use of tree-sitter.