all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Mekeor Melire <mekeor@posteo.de>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Manuel Giraud <manuel@ledu-giraud.fr>,
	68985-done@debbugs.gnu.org
Subject: bug#68985: [PATCH v3] Add option gnus-mode-line-logo
Date: Fri, 09 Feb 2024 20:20:16 -0800	[thread overview]
Message-ID: <87jzndympr.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87h6ih2hnt.fsf@posteo.de> (Mekeor Melire's message of "Sat, 10 Feb 2024 02:03:06 +0000")

Mekeor Melire <mekeor@posteo.de> writes:

> 2024-02-09 15:18 eric@ericabrahamsen.net:
>
>> Looks good! You've tested this, I assume?
>
> Yes.
>
> - Tested the customize interface.
> - Setting to nil works as documented.
> - Setting to another image spec works as documented.
> - As documented, in non-graphical displays (emacs -nw), no logo is
>   displayed, just like before.
> - There are no byte-compilation warnings.
> - There are no new checkdoc warnings.
>
>> I think 'gnus-visual is the right group.
>
> Great!
>
>> Custom types are always a little frustrating, but this might work
>> better:
>>
>> '(choice
>>   (repeat :tag "Image specs" (plist))
>>   (const :tag "No logo" nil))
>
> This is great, too. Find attached another version of the patch which
> uses this custom-type, repeat-(plist).

Looks good! Thanks very much for the work. I've put the patch in. I'll
close the bug but it also occurred to me we didn't put anything in the
manual. I'll take a look at that and maybe follow up with another patch
later.

Thanks,
Eric





  reply	other threads:[~2024-02-10  4:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 22:02 bug#68985: 30.0.50; Gnus: Add option to disable display of logo image in mode-line Mekeor Melire
2024-02-08  1:39 ` Visuwesh
2024-02-08 10:53   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08  6:11 ` Eli Zaretskii
2024-02-08 19:49   ` Mekeor Melire
2024-02-08 22:29     ` Eric Abrahamsen
2024-02-09 10:30       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-09 18:07         ` Eric Abrahamsen
2024-02-09 20:56           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-09 21:53             ` bug#68985: [PATCH v2] Add option gnus-mode-line-logo Mekeor Melire
2024-02-09 23:18               ` Eric Abrahamsen
2024-02-10  2:03                 ` bug#68985: [PATCH v3] " Mekeor Melire
2024-02-10  4:20                   ` Eric Abrahamsen [this message]
2024-02-10  9:07                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-10  7:31               ` bug#68985: [PATCH v2] " Eli Zaretskii
2024-02-10 16:43                 ` Eric Abrahamsen
2024-02-10 22:01                   ` Mekeor Melire
2024-02-11  3:26       ` bug#68985: 30.0.50; Gnus: Add option to disable display of logo image in mode-line Richard Stallman
2024-02-11 15:14         ` Eric Abrahamsen
2024-02-13 21:36           ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzndympr.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=68985-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=manuel@ledu-giraud.fr \
    --cc=mekeor@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.