From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#72358: 29.4; oauth2.el improvements Date: Wed, 31 Jul 2024 10:54:57 +0200 Message-ID: <87jzh2vt3y.fsf@gmail.com> References: <87mslz8yzk.fsf@debian-hx90.lan> <87frrr725m.fsf@gmail.com> <87ed7a8ye6.fsf@debian-hx90.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6017"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72358@debbugs.gnu.org To: Xiyue Deng Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 31 10:56:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sZ58l-0001Da-Oa for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 Jul 2024 10:56:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZ58a-00030u-82; Wed, 31 Jul 2024 04:56:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZ58Y-00030M-Sj for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2024 04:56:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sZ58Y-0006A8-Ii for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2024 04:56:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=BfxBWbDuu3uAZ3fowSfovYANp54HuBKHxvLv3D8m6wc=; b=XzbO7c8qcSeFKn9aXSrciJC6rvBQluE8FSJ/2/no/x/ydC29YzX5nd4orS70dcoziSNQcCaObBKNHWy0vSILF75Y7hJrMQjTnSLrjPQlYMFfhGYdUMrw/heG6NhfwtluX2PqjZ5DW91CBfHzFTL2YH6lRviWhDfETj2T7qCcIrMy+XNqnjItvkPYQcTwmsVhXhvqLcgMeVxbwokuNWJVdzVcHvomBjY4Pa4Yen9L/OtDnnJ/6G270xN+sFGJWEf4LNOKWZkYr8vPhSKeDTaMyYu87BSFd1gbgx/eQV1FMLr4MwJTO7YkcgLENNtB2r1sxhQy0g/+9iV49eUV+ibUNg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sZ58n-0001ZE-Pw for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2024 04:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Jul 2024 08:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72358 X-GNU-PR-Package: emacs Original-Received: via spool by 72358-submit@debbugs.gnu.org id=B72358.17224161855976 (code B ref 72358); Wed, 31 Jul 2024 08:57:01 +0000 Original-Received: (at 72358) by debbugs.gnu.org; 31 Jul 2024 08:56:25 +0000 Original-Received: from localhost ([127.0.0.1]:49091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZ58D-0001YK-2Q for submit@debbugs.gnu.org; Wed, 31 Jul 2024 04:56:25 -0400 Original-Received: from mail-lj1-f170.google.com ([209.85.208.170]:57432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZ589-0001Y3-KA for 72358@debbugs.gnu.org; Wed, 31 Jul 2024 04:56:24 -0400 Original-Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2eeb1ba0481so87196831fa.2 for <72358@debbugs.gnu.org>; Wed, 31 Jul 2024 01:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722416100; x=1723020900; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=BfxBWbDuu3uAZ3fowSfovYANp54HuBKHxvLv3D8m6wc=; b=d5724Q5jFp8zFA1VWut9wQ/MQFYRexvT7SPO06jktAR3cIJXmPA56EHRDm3e3V60kt EAoLoTeP/b4UEMVOuTkMxsKDcMLk8gpM1jSp+ybdPacbcnfoiXlsLPTI0/75c0sPJpTL zxWpChY9tMPXLwvCuWp60g2oTraPlU++j9H7aWgA4kf1K2aJ3drlPtEnTv69lab2OfHg YuSizeFjYPqOfvAf6SMKuFcm5UrD6zYErAfy2NUWvKBR6huAxcLRFw3z83uuWZRg1iQU P7nYEr21A08jPzn7Heor3Ge4PmmwERFNXpC1wVBY8QwWVG8CiQxnx25ZuUTfA001aO7n YpcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722416100; x=1723020900; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BfxBWbDuu3uAZ3fowSfovYANp54HuBKHxvLv3D8m6wc=; b=xBJQQ5/JhEnBnMLd7BHLyAxg7wv+vLVaipweufP2zp32TZaUC/LA+ix28qtRYSBI2d GZpbTtUUsPzrZ07Bg7HRYwRAtyPZcI2Qd5McbXCB6tWg8BDJ/Zh6ARIa5RKOSN6j4ugs rLff7L02sMUZ1D03I4HAkNWdphixhrKne2GTIy80Pgl2WDKtgbCLmgOR5sqHZxlqdQ0K GAxp9Iua2ME+f+HbXkN/tOWYk0t/MDUllQmpjUFnQfX/9YjS2gWffVZ4LWgMOSMkkTJJ OjsvoJ0a6fLX+bYOfpV6G+iJPyrZpEHsBNtimngvYV+fIvd8nVxLwCXoxMRVF+PF4LDH MWlg== X-Gm-Message-State: AOJu0YyRkniA71pSYRVc7tcb/3brlakSr8kCw8uddA+Cn6J2rddrB20r rdm/AerWhZxMFN+tgAxkKsYYXKEAQF1D/YJAE8Maw6vsgm/ANzHYSqPegA== X-Google-Smtp-Source: AGHT+IE7ecRR4LRwUbP9GCkmAFnjyxUtgRqz1DyKEB7XwTXUVyF2D50+1t8up67FIHW8gy5sd/3Zcw== X-Received: by 2002:a2e:9953:0:b0:2ef:2d58:ec24 with SMTP id 38308e7fff4ca-2f12ecd30f5mr89133231fa.17.1722416099420; Wed, 31 Jul 2024 01:54:59 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb51:c026:d246:cbf5:2104]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282babaaa8sm13348935e9.24.2024.07.31.01.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 01:54:58 -0700 (PDT) In-Reply-To: <87ed7a8ye6.fsf@debian-hx90.lan> (Xiyue Deng's message of "Tue, 30 Jul 2024 12:37:05 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289579 Archived-At: >>>>> On Tue, 30 Jul 2024 12:37:05 -0700, Xiyue Deng sa= id: Xiyue> The fifth patch adds debug messages when doing a URL query which= records Xiyue> the request URL, the request data, and the response data, and pr= ovide a Xiyue> custom variable to enable this. This provides a way to help deb= ugging Xiyue> the requests, and I find it handy when testing oauth2 against di= fferent Xiyue> providers. >>=20 >> OK (although perhaps make it a defvar rather than a defcustom, to >> avoid people accidentally enabling it). >>=20 Xiyue> Done also in patch 5. I see you changed `oauth2-token-file' to a `defvar', which I don=CA=BCt think you should do. I was talking about making `oauth2-debug' a defvar. Robert --=20