From: Juri Linkov <juri@linkov.net>
To: Yuan Fu <casouri@gmail.com>
Cc: dmitry@gutov.dev, theo@thornhill.no, 73978@debbugs.gnu.org
Subject: bug#73978: 31.0.50; Text syntax applied on too many things in tsx-ts-mode
Date: Tue, 24 Dec 2024 10:31:33 +0200 [thread overview]
Message-ID: <87jzbpmqhm.fsf@mail.linkov.net> (raw)
In-Reply-To: <87r05xmr24.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 24 Dec 2024 09:59:10 +0200")
> While testing forward-sexp in tsx-ts-mode I noticed that
> this line in 'tsx-ts--s-p-query':
>
> ((jsx_text) @jsx)
>
> disrupts syntax-based navigation for forward-sentence-default-function.
With this patch everything works perfectly:
diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el
index 5c3c9a24ff4..01dd8297996 100644
--- a/lisp/progmodes/typescript-ts-mode.el
+++ b/lisp/progmodes/typescript-ts-mode.el
@@ -630,7 +640,8 @@ tsx-ts--s-p-query
(when (treesit-available-p)
(treesit-query-compile 'tsx
'(((regex pattern: (regex_pattern) @regexp))
- ((jsx_text) @jsx)))))
+ ((jsx_opening_element) @jsx)
+ ((jsx_closing_element) @jsx)))))
(defun typescript-ts--syntax-propertize (beg end)
(let ((captures (treesit-query-capture 'typescript typescript-ts--s-p-query beg end)))
next prev parent reply other threads:[~2024-12-24 8:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 4:06 bug#73978: 31.0.50; Text syntax applied on too many things in tsx-ts-mode Yuan Fu
2024-11-09 9:11 ` Eli Zaretskii
2024-11-09 16:49 ` Yuan Fu
2024-11-23 12:15 ` Eli Zaretskii
2024-11-24 5:25 ` Yuan Fu
2024-11-24 7:47 ` Eli Zaretskii
2024-11-24 13:45 ` Dmitry Gutov
2024-11-25 1:27 ` Yuan Fu
2024-12-11 4:52 ` Yuan Fu
2024-12-12 2:52 ` Dmitry Gutov
2024-12-12 4:56 ` Yuan Fu
2024-12-12 17:19 ` Dmitry Gutov
2024-12-13 5:47 ` Yuan Fu
2024-12-24 7:59 ` Juri Linkov
2024-12-24 8:31 ` Juri Linkov [this message]
2024-12-24 8:52 ` Yuan Fu
2024-12-24 17:25 ` Juri Linkov
2024-12-24 20:57 ` Yuan Fu
2024-12-25 7:40 ` Juri Linkov
2024-12-25 8:33 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzbpmqhm.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=73978@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.