From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id AJI1AVxYbWcbeAAAqHPOHw:P1 (envelope-from ) for ; Thu, 26 Dec 2024 13:21:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id AJI1AVxYbWcbeAAAqHPOHw (envelope-from ) for ; Thu, 26 Dec 2024 14:21:32 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=SnADCMC2; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735219291; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oERjPAMpC426V0ZVeWtZMc2VDriCLQsshGPRzWAT7Fk=; b=oeGmSsJKUrzesASBBd3gZe4lKa/qyo6HB58Eah9MljCJR8QvpEH7cDpaIthrcJTLJtGhnn kH6EnVkrlwNhDjLV4UxlPbFTKBt4qeNY7MGEbBIBZgOBaNjZC+SS5qKCWO82MWX4+FLP0T t2gYsx3TVRRsOwWpiHYekLVBngsCde6NK2S3/NyKMYwAzo+z8cufYgwR4z1fO+RUns6NCu wJrMGd4VTGyZku+6vsYKuCTSLK7QUbylTlo//MHCTOpjcEP2MfO10FBuG0OFwLfanDshWc sIgwWSq85kmoenl8Dwq2L6vqHCWdbc0FfpnWHMmCiW0nmmsuPZXIJGIcCjaOKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=SnADCMC2; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735219291; a=rsa-sha256; cv=none; b=Km4p+gnFa8xaCHNlFq+52A/g5ZuJUlysxP5GxIkjAxLgydTPybrziuA0XxOGOrtgHF/iSh n4bR95yMs/yiZxJdC/mFoxKPsW4Y2S7RJaVyJLyBbkvm78NV2gNPOS8bqmLs/f94MC3QW+ /DGxKa6mdLUgon+0XjXnABj2a8bR6Tju/jELIJBaVdDrGUR7ptORrDeAOWvn8U/nvaKwlB g4YH4Kdzi0VYxm0QFHefgHOXdxdTMSYM3uYVN35joHebOqjRQb/aFW14ukQTtFqmBWZcwG yhqaUvRW0EPtwUHaQFVynIQKMi5m71JJIFzDwmxirbLqRq2dxWtZ4Rm+WAXdlw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C951D1E9E7 for ; Thu, 26 Dec 2024 14:21:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQnnB-0005vz-7S; Thu, 26 Dec 2024 08:20:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQnn5-0005vg-8U for emacs-orgmode@gnu.org; Thu, 26 Dec 2024 08:20:39 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQnn0-0004YJ-RO for emacs-orgmode@gnu.org; Thu, 26 Dec 2024 08:20:37 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E9BE0240027 for ; Thu, 26 Dec 2024 14:20:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735219231; bh=HIKB4+Q5A6H6/7uciBqCpiOFlAtJ++mHTUNVxsUBGhc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=SnADCMC2n7y2jcc59Q1BoqbN8AjyxBXlutDWPQzY2rmMbTQK5NkwCQrnYjIXRCooD qPGRnMMto5NruvqxoHVUCXrunW4rp8VKyfxZ8bqukQrm/47JSkdaR/DUNJGjFyLpn1 Dmq8ngAnAZ/Ij86th9ABcGqtvfsZYsf7S/R478Xw7wwATJHABLtB/1J5ZFTQ129JDy KLkriw7Yrq6B3Mv2eg+J8apVjMJHvvZOOZTvGthMqBx1svllokdDyt/+6z24gE2Xk3 EDLz8GGlshRZL/N2gpAiit80bB366Dm0CXUwPGl+a+jGzWtqsD9IcUft7FGIIUpckp eZGFJlWOarFEA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YJq4b1MmSz6tvk; Thu, 26 Dec 2024 14:20:31 +0100 (CET) From: Ihor Radchenko To: Visuwesh Cc: Org Mode List Subject: Re: Unexpected error using org-gnus-follow-link In-Reply-To: <87cyheehc6.fsf@gmail.com> References: <874j39vz29.fsf@ucl.ac.uk> <87y10lhrlb.fsf@gmail.com> <878qsku5rp.fsf@ucl.ac.uk> <87cyhw3zrp.fsf@gmail.com> <87a5cn998u.fsf@localhost> <87pllic102.fsf@gmail.com> <87jzbqluk9.fsf@localhost> <87cyheehc6.fsf@gmail.com> Date: Thu, 26 Dec 2024 13:22:01 +0000 Message-ID: <87jzbm7f5y.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -7.27 X-Spam-Score: -7.27 X-Migadu-Queue-Id: C951D1E9E7 X-Migadu-Scanner: mx10.migadu.com X-TUID: sayFicMgel3F Visuwesh writes: >> Also, (cdr (assq 'gnus org-link-frame-setup)) = nil is not the only >> possible incorrect customization. I'd rather check if the cdr is a >> function and throw a descriptive error otherwise asking to fix >> `org-link-frame-setup'. > > How about the attached? You still do not check if the value is a function. Consider totally wrong values like '(wrong). `fboundp' will then throw an error. You may consider `functionp' instead. > +(defun org-link-frame-setup-function (link-type) > + "Return the frame setup function for the link type LINK-TYPE. > +This signals an error if the value of the key LINK-TYPE in > +`org-link-frame-setup' is not a function." > + (let ((fun (cdr (assq link-type org-link-frame-setup)))) > + (if (fboundp fun) > + fun > + (error "The frame setup configuration for `%s' link type is ill-defined" > + link-type)))) In the error, we can also show the problematic value to aid the user. > @@ -15311,20 +15311,20 @@ (defun org-modify-ts-extra (ts-string pos nincrements increment-step) > (setq hour (mod hour 24)) > (setq pos-match-group 1 > new (format "-%02d:%02d" hour minute))) > - > + > ... Please remove irrelevant whitespace-only changes. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at