From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: New "make benchmark" target Date: Tue, 31 Dec 2024 04:00:05 +0000 Message-ID: <87jzbgpkon.fsf@protonmail.com> References: <87h679kftn.fsf@protonmail.com> <87frm51jkr.fsf@protonmail.com> <861pxpp88q.fsf@gnu.org> <87frm5z06l.fsf@protonmail.com> <86msgdnqmv.fsf@gnu.org> <87wmfhxjce.fsf@protonmail.com> <86jzbhnmzg.fsf@gnu.org> <87o70txew4.fsf@protonmail.com> <86frm5nii8.fsf@gnu.org> Reply-To: Pip Cet Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39167"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, stefankangas@gmail.com, mattiase@acm.org, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 31 13:16:51 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSbB4-000A1l-Ra for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Dec 2024 13:16:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSb9d-0004NS-Gr; Tue, 31 Dec 2024 07:15:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSTQW-0001PX-9V for emacs-devel@gnu.org; Mon, 30 Dec 2024 23:00:16 -0500 Original-Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSTQU-0002sD-0F; Mon, 30 Dec 2024 23:00:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1735617609; x=1735876809; bh=h4INO49VPILfWt4sriKTs57bRYtwvqDEl/ezrV7Orkk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=YwfrsS/K5NbiQ4IVAsK4bkor5kWRQSRzwsFWFK3WY0BiqaxykpmoXb0EpDLZeVtw5 bnj3PGBBHzAJbRvkAnQb58V/WhECOkrtrFwPy0KI4p7IL7g4QO9R8T1BzAKTmK2GCt 6+71pnTacGRN+kWTubf24HFZTQGMoTc3a/2491YQNEEaJDj2zFxyR1XLIkWUZLve5u ekIrMNY9Qc9dxawNkEBMvxct/D3EpgCS+4Ssmie0suIx/LKAlSzB7/f4TzBsuUfspc KKGN4LJ6SyeczQ19pics46uQ2kdEniDKQRYpDkm7k+Rr46aFusAs0jPPUZrUgQ6Hix OalCt3RmxYPng== In-Reply-To: <86frm5nii8.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 4eb67a540da4fa114e6dca6ba0bed3c560f0ece3 Received-SPF: pass client-ip=185.70.43.22; envelope-from=pipcet@protonmail.com; helo=mail-4322.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 31 Dec 2024 07:15:15 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327494 Archived-At: "Eli Zaretskii" writes: >> Date: Mon, 30 Dec 2024 17:25:44 +0000 >> From: Pip Cet >> Cc: acorallo@gnu.org, stefankangas@gmail.com, mattiase@acm.org, eggert@c= s.ucla.edu, emacs-devel@gnu.org >> >> "Eli Zaretskii" writes: >> >> Top-posted TL;DR: let's call Andrea's code "make elisp-benchmarks" and >> include it now? That would preserve the Git history and importantly (to >> me) reserve the name for now. > > Fine by me. Pushed to scratch/elisp-benchmarks. Sorry for all the noise; we should really find a way to reduce emacs-diffs notifications when many commits are made at once. This branch: 1. contains whitespace errors, because it contains the files precisely as they are in the elisp-benchmarks repo 2. contains the admin/elpa2emacs script, based on the assessment by the one author who doesn't have a copyright assignment that less than 15 lines of his original code remain. I made it the last commit in the series so it's easy to drop that specific commit and merge the rest. 3. creates a top-level elisp-benchmarks directory >> And I don't usually run ERT tests individually, while I'm trying to get >> in the habit of running the (non-expensive) test suite before I push. > > I do it all the time, when I install some change and want to make sure > the related tests still pass. Interesting: I find it very hard to localize my changes to specific tests, usually. >> My preference would be a top-level directory called "elisp-benchmarks", >> but ultimately that's a minor question, so just let me know the >> preferred destination. > > I thought we wanted it under test/ ? > > But I'm also okay with having a directory that is sibling to test/ if > there are no objections from Andrea and others. Obviously, it's not too late for such objections. That's why I wanted to include the script: redoing the merge that way is much easier than applying git filter-repo to a "live" Emacs repo (which is destroyed in the process). Pip