Re: New "make benchmark" target

[Pip Cet via "Emacs development discussions." <emacs-devel@gnu.org>]

"Eli Zaretskii" <eliz@gnu.org> writes:

>> Date: Mon, 30 Dec 2024 17:25:44 +0000
>> From: Pip Cet <pipcet@protonmail.com>
>> Cc: acorallo@gnu.org, stefankangas@gmail.com, mattiase@acm.org, eggert@cs.ucla.edu, emacs-devel@gnu.org
>>
>> "Eli Zaretskii" <eliz@gnu.org> writes:
>>
>> Top-posted TL;DR: let's call Andrea's code "make elisp-benchmarks" and
>> include it now?  That would preserve the Git history and importantly (to
>> me) reserve the name for now.
>
> Fine by me.

Pushed to scratch/elisp-benchmarks.  Sorry for all the noise; we should
really find a way to reduce emacs-diffs notifications when many commits
are made at once.

This branch:

1. contains whitespace errors, because it contains the files precisely
as they are in the elisp-benchmarks repo

2. contains the admin/elpa2emacs script, based on the assessment by the
one author who doesn't have a copyright assignment that less than 15
lines of his original code remain.  I made it the last commit in the
series so it's easy to drop that specific commit and merge the rest.

3. creates a top-level elisp-benchmarks directory

>> And I don't usually run ERT tests individually, while I'm trying to get
>> in the habit of running the (non-expensive) test suite before I push.
>
> I do it all the time, when I install some change and want to make sure
> the related tests still pass.

Interesting: I find it very hard to localize my changes to specific
tests, usually.

>> My preference would be a top-level directory called "elisp-benchmarks",
>> but ultimately that's a minor question, so just let me know the
>> preferred destination.
>
> I thought we wanted it under test/ ?
>
> But I'm also okay with having a directory that is sibling to test/ if
> there are no objections from Andrea and others.

Obviously, it's not too late for such objections.  That's why I wanted
to include the script: redoing the merge that way is much easier than
applying git filter-repo to a "live" Emacs repo (which is destroyed in
the process).

Pip