respect active region in browse-url.el

respect active region in browse-url.el

[Yoichi NAKAYAMA]

Hi,

Url in text sometimes splits into lines and
`browse-url-url-at-point' detects only a part.
Following change enables a user to explicitly
specify url string part in text.

emacs-w3m (http://emacs-w3m.namazu.org/index-en.html)
has such feature and I'm using it conveniently.

Index: browse-url.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/net/browse-url.el,v
retrieving revision 1.36
diff -u -r1.36 browse-url.el
--- browse-url.el	27 Apr 2004 14:03:10 -0000	1.36
+++ browse-url.el	22 May 2004 06:33:58 -0000
@@ -583,7 +583,13 @@
 negation if a prefix argument was given."
   (let ((event (elt (this-command-keys) 0)))
     (and (listp event) (mouse-set-point event)))
-  (list (read-string prompt (browse-url-url-at-point))
+  (list (read-string prompt (or (and transient-mark-mode mark-active
+				     ;; rfc2396 Appendix E.
+				     (replace-regexp-in-string
+				      "[\t\r\f\n ]+" ""
+				      (buffer-substring-no-properties
+				       (region-beginning) (region-end))))
+				(browse-url-url-at-point)))
 	(not (eq (null browse-url-new-window-flag)
 		 (null current-prefix-arg)))))
 

Reference: http://www.faqs.org/rfcs/rfc2396.html

Regards,
-- 
Yoichi NAKAYAMA

Re: respect active region in browse-url.el

[Richard Stallman]

Your change looks good.  Would someone please install it?


Index: browse-url.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/net/browse-url.el,v
retrieving revision 1.36
diff -u -r1.36 browse-url.el
--- browse-url.el	27 Apr 2004 14:03:10 -0000	1.36
+++ browse-url.el	22 May 2004 06:33:58 -0000
@@ -583,7 +583,13 @@
 negation if a prefix argument was given."
   (let ((event (elt (this-command-keys) 0)))
     (and (listp event) (mouse-set-point event)))
-  (list (read-string prompt (browse-url-url-at-point))
+  (list (read-string prompt (or (and transient-mark-mode mark-active
+				     ;; rfc2396 Appendix E.
+				     (replace-regexp-in-string
+				      "[\t\r\f\n ]+" ""
+				      (buffer-substring-no-properties
+				       (region-beginning) (region-end))))
+				(browse-url-url-at-point)))
 	(not (eq (null browse-url-new-window-flag)
 		 (null current-prefix-arg)))))