From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: syntax-after Date: Tue, 23 Nov 2004 08:27:55 +0200 Organization: JURTA Message-ID: <87is7xozd8.fsf@jurta.org> References: <87mzxoc8bi.fsf-monnier+emacs@gnu.org> <87brdqe88y.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1101191454 3261 80.91.229.6 (23 Nov 2004 06:30:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 23 Nov 2004 06:30:54 +0000 (UTC) Cc: emacs-devel@gnu.org, rms@gnu.org, storm@cua.dk Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 23 07:30:48 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CWUCO-0002fi-00 for ; Tue, 23 Nov 2004 07:30:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CWULT-0005IR-Qb for ged-emacs-devel@m.gmane.org; Tue, 23 Nov 2004 01:40:11 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CWULI-0005IK-DO for emacs-devel@gnu.org; Tue, 23 Nov 2004 01:40:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CWULI-0005I8-05 for emacs-devel@gnu.org; Tue, 23 Nov 2004 01:40:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CWULH-0005I5-Tl for emacs-devel@gnu.org; Tue, 23 Nov 2004 01:39:59 -0500 Original-Received: from [66.33.205.9] (helo=spatula.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CWUC5-0001Fp-B5; Tue, 23 Nov 2004 01:30:29 -0500 Original-Received: from mail.jurta.org (80-235-40-48-dsl.mus.estpak.ee [80.235.40.48]) by spatula.dreamhost.com (Postfix) with ESMTP id 9F79A17D015; Mon, 22 Nov 2004 22:30:24 -0800 (PST) Original-To: Stefan Monnier In-Reply-To: (Stefan Monnier's message of "Mon, 22 Nov 2004 12:15:39 -0500") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30273 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30273 Stefan Monnier writes: >>>> I don't know if I will have net access this week--could you please >>>> undo it? >>> Done, >> It seems you forgot to undo changes to etc/NEWS and syntax.texi... > > Oops, sorry. I've fixed etc/NEWS and syntax.texi. > Any other place? You have reverted the changes in paren.el to old code: (dir (cond ((eq (car (syntax-after (1- (point)))) 5) -1) ((eq (car (syntax-after (point))) 4) 1))) but this code is really bad, since it uses raw enum values 4 and 5 which are nowhere documented and too implementation specific. You already proposed a new function `syntax-class'. This would improve the code. I also think there should exist another function returning a complete syntax string with all flags (e.g. `syntax-to-string'). Such C function could be created from `internal-describe-syntax-value' (up to the line inserting "\twhich means:") with moving the rest of the code in `internal-describe-syntax-value' (which just inserts a readable syntax description) to Lisp side (e.g. to subr.el). -- Juri Linkov http://www.jurta.org/emacs/