From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: flyspell bug Date: Tue, 10 May 2005 08:04:07 +0300 Organization: JURTA Message-ID: <87is1roent.fsf@jurta.org> References: <01c5531e$Blat.v2.4$ea8d9a00@zahav.net.il> <87zmv3rg09.fsf_-_@jurta.org> <01c55511$Blat.v2.4$cb2c24c0@zahav.net.il> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1115703083 20970 80.91.229.2 (10 May 2005 05:31:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 10 May 2005 05:31:23 +0000 (UTC) Cc: s.j.eglen@damtp.cam.ac.uk, mange@freemail.hu, public@heslin.eclipse.co.uk, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 10 07:31:21 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DVNKw-0004yK-Ax for ged-emacs-devel@m.gmane.org; Tue, 10 May 2005 07:31:18 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DVNTP-0007dw-Cp for ged-emacs-devel@m.gmane.org; Tue, 10 May 2005 01:40:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DVNPT-0006gO-TD for emacs-devel@gnu.org; Tue, 10 May 2005 01:36:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DVNPH-0006b2-Ov for emacs-devel@gnu.org; Tue, 10 May 2005 01:35:52 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DVNPF-0006Rs-1A for emacs-devel@gnu.org; Tue, 10 May 2005 01:35:45 -0400 Original-Received: from [194.126.101.98] (helo=MXR-2.estpak.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DVNEe-0005o0-82; Tue, 10 May 2005 01:24:48 -0400 Original-Received: from mail.neti.ee (80-235-35-221-dsl.mus.estpak.ee [80.235.35.221]) by MXR-2.estpak.ee (Postfix) with ESMTP id 39FA3132ACC; Tue, 10 May 2005 08:18:23 +0300 (EEST) Original-To: Eli Zaretskii In-Reply-To: <01c55511$Blat.v2.4$cb2c24c0@zahav.net.il> (Eli Zaretskii's message of "Tue, 10 May 2005 06:37:53 +0300") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36932 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36932 >> Index: lisp/textmodes/ispell.el >> =================================================================== >> RCS file: /cvsroot/emacs/emacs/lisp/textmodes/ispell.el,v >> retrieving revision 1.162 >> diff -u -r1.162 ispell.el >> --- lisp/textmodes/ispell.el 7 May 2005 16:04:39 -0000 1.162 >> +++ lisp/textmodes/ispell.el 10 May 2005 00:05:05 -0000 >> @@ -302,7 +302,8 @@ >> :group 'ispell) >> >> (defcustom ispell-program-name >> - (or (locate-file "aspell" exec-path exec-suffixes 'file-executable-p) >> + (or (and ispell-really-aspell >> + (locate-file "aspell" exec-path exec-suffixes 'file-executable-p)) >> "ispell") > > ??? Does this really work? AFAIK, ispell-really-aspell is set when > ispell.el invokes the speller for the first time, not before that. So > this defcustom wuill never try aspell, I think. This may be needed when users set `ispell-really-aspell' explicitly in .emacs. However, after looking at ispell.el it seems that `ispell-check-version' always is called before invoking the speller for the first time. So maybe the second part of my patch makes the search for aspell in defcustom unnecessary, and its initial value should be reverted to "ispell". Note that automatic changing the value of `ispell-program-name' in `ispell-check-version' might surprise users of the aspell's implementation of ispell. Anyhow, this is the better place to change ispell program name to "aspell" than defcustom. -- Juri Linkov http://www.jurta.org/emacs/