From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Arne =?iso-8859-1?Q?J=F8rgensen?= Newsgroups: gmane.emacs.devel Subject: Re: latexenc and `TeX-master' Date: Tue, 24 Jan 2006 00:04:37 +0100 Organization: Arne Joergensen -- http://arnested.dk/ Message-ID: <87irsasfzu.fsf@arnested.dk> References: <86169402-381A-4DAD-AF54-72DE99CD1959@gmail.com> <87y818z6fp.fsf@arnested.dk> <878xt8uqk9.fsf@arnested.dk> <7F98F161-442F-40A7-9F67-563168439D3B@gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1138057540 13820 80.91.229.2 (23 Jan 2006 23:05:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Jan 2006 23:05:40 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 24 00:05:39 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F1AkY-0000LY-WA for ged-emacs-devel@m.gmane.org; Tue, 24 Jan 2006 00:05:28 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F1AnC-0005dA-MK for ged-emacs-devel@m.gmane.org; Mon, 23 Jan 2006 18:08:10 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F1Amx-0005c7-9m for emacs-devel@gnu.org; Mon, 23 Jan 2006 18:07:56 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F1Amw-0005bc-91 for emacs-devel@gnu.org; Mon, 23 Jan 2006 18:07:54 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F1Amw-0005bV-3I for emacs-devel@gnu.org; Mon, 23 Jan 2006 18:07:54 -0500 Original-Received: from [80.91.229.2] (helo=ciao.gmane.org) by monty-python.gnu.org with esmtp (TLS-1.0:RSA_AES_128_CBC_SHA:16) (Exim 4.34) id 1F1Ark-0000sU-4f for emacs-devel@gnu.org; Mon, 23 Jan 2006 18:12:52 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1F1Ajy-0000Cw-UI for emacs-devel@gnu.org; Tue, 24 Jan 2006 00:04:51 +0100 Original-Received: from 213.237.94.152 ([213.237.94.152]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 24 Jan 2006 00:04:50 +0100 Original-Received: from arne by 213.237.94.152 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 24 Jan 2006 00:04:50 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 48 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 213.237.94.152 X-Face: 5t,7/Y$&<1A_t.$vC2{pWZ{m@3_06; kcm]no{hgEL/}Uz(>XV6cl4}xO\v?-h3%>znNaZtq `~rf,GY1T%r=a.zH`hOb(-]'x)nI088Z&|e;V^h;/TShou User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:qVxyuzlC7fzOVbwlUkCQupHaMng= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49467 Archived-At: David Reitter writes: > On 22 Jan 2006, at 17:21, Arne Jørgensen wrote: > >> Arne Jørgensen writes: >> >>> But it is probably better to check if the file is a regular and then >>> also check if it is actually readable. >> >> Readability is already checked later in the code. Checking whether the >> file is a regular file is also better checked at that point. > > yes, I agree. The second change (below) should catch all other cases. > > > *** latexenc.el 02 Dec 2005 13:24:11 +0000 1.11 > --- latexenc.el 22 Jan 2006 08:52:12 +0000 > *************** > *** 174,180 **** > (find-file-noselect latexenc-main-file t))) > (coding-system-base ;Disregard the EOL part of > the CS. > (with-current-buffer latexenc-main-buffer > ! (or coding-system-for-write buffer-file-coding- > system)))) > 'undecided)))) > 'undecided)) > > --- 175,183 ---- > (find-file-noselect latexenc-main-file t))) > (coding-system-base ;Disregard the EOL part of > the CS. > (with-current-buffer latexenc-main-buffer > ! (or coding-system-for-write > ! buffer-file-coding-system > ! 'undecided)))) > 'undecided)))) > 'undecided)) On a first read I just thought this fix was a reindentation of the code, but now that I've read it more carefully I think it should be applied :-) Kind regards /arne -- Arne Jørgensen