From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: recent changes to display code Date: Wed, 07 Nov 2007 10:35:25 -0500 Message-ID: <87ir4eoypu.fsf@stupidchicken.com> References: <8qejf4p01c.fsf@fencepost.gnu.org> <87sl3kkmmw.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1194449883 20055 80.91.229.12 (7 Nov 2007 15:38:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Nov 2007 15:38:03 +0000 (UTC) Cc: rgm@gnu.org, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 07 16:38:06 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IpmyT-0006EP-63 for ged-emacs-devel@m.gmane.org; Wed, 07 Nov 2007 16:37:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IpmyI-0004gy-3h for ged-emacs-devel@m.gmane.org; Wed, 07 Nov 2007 10:37:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IpmxB-0003hX-Vg for emacs-devel@gnu.org; Wed, 07 Nov 2007 10:36:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IpmxA-0003fb-7O for emacs-devel@gnu.org; Wed, 07 Nov 2007 10:36:29 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IpmxA-0003fY-4r for emacs-devel@gnu.org; Wed, 07 Nov 2007 10:36:28 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ipmx3-0000Qq-KF; Wed, 07 Nov 2007 10:36:21 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 2DDD44E38B; Wed, 7 Nov 2007 10:35:25 -0500 (EST) In-Reply-To: (Richard Stallman's message of "Tue\, 06 Nov 2007 19\:15\:26 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82746 Archived-At: Richard Stallman writes: > I'm surprised that this change affected any behavior. It was only > supposed to make the argument OVERLAY available to > face_for_overlay_string. I will take another look to see what might > have caused such a problem. > > I wonder if there is some hidden constraint on the order of fields in > `struct it'. No, the bug arises because of a rather strange (presumable) typo in your definition of from_overlay in handle_face_prop: Lisp_Object from_overlay = (it->current.overlay_string_index >= 0 ? it->string_overlays[it->current.overlay_string_index] : from_overlay); ^^^^^^^^^^^^ I've fixed this in EMACS_22_BASE.