From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Faces applies to new frames Date: Sat, 28 Jun 2008 22:48:33 -0400 Message-ID: <87iqvtgdmm.fsf@stupidchicken.com> References: <87k5gbx12n.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1214707731 26063 80.91.229.12 (29 Jun 2008 02:48:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Jun 2008 02:48:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 29 04:49:37 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KCmys-0007jW-GI for ged-emacs-devel@m.gmane.org; Sun, 29 Jun 2008 04:49:34 +0200 Original-Received: from localhost ([127.0.0.1]:56215 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KCmy2-0002QP-Ey for ged-emacs-devel@m.gmane.org; Sat, 28 Jun 2008 22:48:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KCmxw-0002Iv-49 for emacs-devel@gnu.org; Sat, 28 Jun 2008 22:48:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KCmxv-0002Gk-4q for emacs-devel@gnu.org; Sat, 28 Jun 2008 22:48:35 -0400 Original-Received: from [199.232.76.173] (port=35808 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KCmxv-0002GW-0m for emacs-devel@gnu.org; Sat, 28 Jun 2008 22:48:35 -0400 Original-Received: from c-24-63-201-57.hsd1.ma.comcast.net ([24.63.201.57]:14955 helo=furry) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KCmxu-0000Qx-MV for emacs-devel@gnu.org; Sat, 28 Jun 2008 22:48:34 -0400 Original-Received: by furry (Postfix, from userid 1000) id 883E5C054; Sat, 28 Jun 2008 22:48:34 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Thu, 26 Jun 2008 21:28:48 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100111 Archived-At: Regarding your recent change to face-set-after-frame-default: in the loop that initializes faces from face specs and X resources, I believe the reason this excluded the `default' face is that the `default' face's attributes are supposed to be applied right at the beginning of face-set-after-frame-default: (if (face-attribute 'default :font t) (set-face-attribute 'default frame :font (face-attribute 'default :font t)) (set-face-attribute 'default frame :family (face-attribute 'default :family t)) (set-face-attribute 'default frame :height (face-attribute 'default :height t)) .... Thus, the function is simply trying to avoid doing the work twice. The question is, why does this reasoning break down, leading to the bugs that you supposedly fixed with your change?