From: Sven Joachim <svenjoac@gmx.de>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Kevin Ryde <user42@zip.com.au>, 407@emacsbugs.donarmstrong.com
Subject: bug#407: gpm server stop making emacs abort()
Date: Tue, 01 Jul 2008 22:43:40 +0200 [thread overview]
Message-ID: <87iqvpgwsj.fsf@gmx.de> (raw)
In-Reply-To: <mailman.13216.1213396033.18990.bug-gnu-emacs@gnu.org> (Stefan Monnier's message of "Fri, 13 Jun 2008 18:18:32 -0400")
[ Stefan, it seems you inadvertently forgot to CC the bug submitter,
which is why you did not get an answer from him.]
On 2008-06-14 00:18 +0200, Stefan Monnier wrote:
>> If running with
>> (gpm-mouse-mode 1)
>> and if you stop the gpm server, then emacs dies with
>> Fatal error (6)Aborted
I also saw that. When gpm was upgraded and restarted, Emacs aborted.
>> Output from "bt full" below; xbacktrace printed nothing at all.
>
>> The backtrace shows it at the abort() under the EBADF case in
>> wait_reading_process_output(). I think when Gpm_GetEvent gets an eof
>> from the server it closes gpm_fd; maybe that's the bad fd in question.
>
> I can't test it right now. Does the patch below help?
>
>
> Stefan
>
>
> --- keyboard.c.~1.959.~ 2008-06-03 02:14:30.000000000 -0400
> +++ keyboard.c 2008-06-13 18:17:35.000000000 -0400
> @@ -7189,6 +7189,8 @@
> while (gpm = Gpm_GetEvent (&event), gpm == 1) {
> nread += handle_one_term_event (tty, &event, &hold_quit);
> }
> + if (gpm < 0)
> + delete_gpm_wait_descriptor (gpm_fd);
> if (hold_quit.kind != NO_EVENT)
> kbd_buffer_store_event (&hold_quit);
> if (nread)
Works fine for me.
Regards,
Sven
next prev parent reply other threads:[~2008-07-01 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jwvocvndjs1.fsf-monnier+emacsbugreports@gnu.org>
2008-06-13 20:55 ` bug#407: gpm server stop making emacs abort() Kevin Ryde
2008-06-13 22:18 ` Stefan Monnier
[not found] ` <mailman.13216.1213396033.18990.bug-gnu-emacs@gnu.org>
2008-07-01 20:43 ` Sven Joachim [this message]
2008-07-03 22:00 ` Kevin Ryde
2008-09-12 4:14 ` Stefan Monnier
2008-09-12 5:54 ` Sven Joachim
2008-09-12 17:08 ` Stefan Monnier
2008-10-30 22:11 ` Kevin Ryde
2009-03-27 16:25 ` bug#407: marked as done (gpm server stop making emacs abort()) Emacs bug Tracking System
[not found] ` <handler.407.D407.123817070925838.notifdone@emacsbugs.donarmstrong.com>
2009-03-28 0:46 ` bug#407: closed by Stefan Monnier <monnier@iro.umontreal.ca> " Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqvpgwsj.fsf@gmx.de \
--to=svenjoac@gmx.de \
--cc=407@emacsbugs.donarmstrong.com \
--cc=monnier@IRO.UMontreal.CA \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.