From: Chong Yidong <cyd@stupidchicken.com>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: Dan Nicolaescu <dann@ics.uci.edu>, Emacs Devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog
Date: Wed, 10 Dec 2008 11:35:26 -0500 [thread overview]
Message-ID: <87iqpsrnsh.fsf@cyd.mit.edu> (raw)
In-Reply-To: <f7ccd24b0812100820g10908082p5c74f899ea6b2bf8@mail.gmail.com> (Juanma Barranquero's message of "Wed, 10 Dec 2008 17:20:28 +0100")
"Juanma Barranquero" <lekktu@gmail.com> writes:
> But the base discussion is whether features should be tested by
> feature tests, or lumped together into the WINDOWSNT, DOS_NT,
> NS_IMPL_* bags. We've been saying for years that Emacs lisp programs
> must not check the Emacs version, but features. The same reasoning
> applies to checking HAVE_DAEMON vs. WINDOWSNT.
That's typically true, but again: specifics matter. For instance, if
the majority of the code controlled by the HAVE_DAEMON macro is
platform-dependent anyway, we would simply be replacing
#ifdef WINDOWSNT
...
#endif
with
#ifdef HAVE_DAEMON
#ifdef WINDOWSNT
...
#endif
...
#endif
Which situation pertains in the actual code?
next prev parent reply other threads:[~2008-12-10 16:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1LAQV6-0003hq-HV@cvs.savannah.gnu.org>
2008-12-10 15:01 ` [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog Juanma Barranquero
2008-12-10 15:25 ` Juanma Barranquero
2008-12-10 15:46 ` Dan Nicolaescu
2008-12-10 15:54 ` Juanma Barranquero
2008-12-10 16:15 ` Chong Yidong
2008-12-10 16:20 ` Juanma Barranquero
2008-12-10 16:35 ` Chong Yidong [this message]
2008-12-10 16:50 ` Juanma Barranquero
2008-12-10 16:40 ` Jason Rumney
2008-12-10 16:46 ` Juanma Barranquero
2008-12-10 16:55 ` Dan Nicolaescu
2008-12-10 19:26 ` Lennart Borgman
2008-12-10 19:36 ` Dan Nicolaescu
2008-12-10 19:51 ` Lennart Borgman
2008-12-10 20:03 ` Dan Nicolaescu
2008-12-10 20:18 ` Lennart Borgman
2008-12-10 20:26 ` Dan Nicolaescu
2008-12-10 20:34 ` Lennart Borgman
2008-12-10 16:31 ` Dan Nicolaescu
2008-12-10 16:33 ` Harald Hanche-Olsen
[not found] <E1LAYb6-0004jn-HF@cvs.savannah.gnu.org>
2008-12-10 23:45 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iqpsrnsh.fsf@cyd.mit.edu \
--to=cyd@stupidchicken.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.