From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#1852: 23.0.60; describe-face: Wrong type argument: symbolp, (:slant oblique) Date: Mon, 12 Jan 2009 13:19:07 +0100 Message-ID: <87iqokra2s.fsf@escher.local.home> References: <87vdslfpdi.fsf@escher.local.home> <87ljthfdu2.fsf@cyd.mit.edu> Reply-To: Stephen Berman , 1852@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1231764297 28139 80.91.229.12 (12 Jan 2009 12:44:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 12 Jan 2009 12:44:57 +0000 (UTC) Cc: 1852@emacsbugs.donarmstrong.com To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 12 13:46:08 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LMMBC-0006qS-5I for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Jan 2009 13:46:06 +0100 Original-Received: from localhost ([127.0.0.1]:39244 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMM9v-0001yV-Uy for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Jan 2009 07:44:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LMM8l-0000ay-D4 for bug-gnu-emacs@gnu.org; Mon, 12 Jan 2009 07:43:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LMM8g-0000Tj-G0 for bug-gnu-emacs@gnu.org; Mon, 12 Jan 2009 07:43:34 -0500 Original-Received: from [199.232.76.173] (port=42419 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMM8g-0000TJ-0D for bug-gnu-emacs@gnu.org; Mon, 12 Jan 2009 07:43:30 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:56202) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LMM8f-0005lu-Dz for bug-gnu-emacs@gnu.org; Mon, 12 Jan 2009 07:43:29 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0CChPfh012468; Mon, 12 Jan 2009 04:43:25 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0CCP3GG007692; Mon, 12 Jan 2009 04:25:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stephen Berman Original-Sender: steve@escher.local.home Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 12 Jan 2009 12:25:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1852 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1852-submit@emacsbugs.donarmstrong.com id=B1852.12317627646300 (code B ref 1852); Mon, 12 Jan 2009 12:25:03 +0000 Original-Received: (at 1852) by emacsbugs.donarmstrong.com; 12 Jan 2009 12:19:24 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id n0CCJFMd006294 for <1852@emacsbugs.donarmstrong.com>; Mon, 12 Jan 2009 04:19:17 -0800 Original-Received: (qmail invoked by alias); 12 Jan 2009 12:19:09 -0000 Original-Received: from i59F5702E.versanet.de (EHLO escher.local.home) [89.245.112.46] by mail.gmx.net (mp047) with SMTP; 12 Jan 2009 13:19:09 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1+y1cVwAJiyyTXxoGsIMedw3oCZqoJDqVYb+8t+ik 7+5bxLCeqoucRZ Original-Received: by escher.local.home (Postfix, from userid 1000) id 705051D103C; Mon, 12 Jan 2009 13:19:07 +0100 (CET) In-Reply-To: <87ljthfdu2.fsf@cyd.mit.edu> (Chong Yidong's message of "Sun, 11 Jan 2009 21:38:45 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.54 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 12 Jan 2009 07:43:34 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24024 Archived-At: On Sun, 11 Jan 2009 21:38:45 -0500 Chong Yidong wrote: > Stephen Berman writes: > >> Your fix prevents the error from being raised at step 4 above; however, >> the behavior is nevertheless still not what I would naively expect: >> namely, now it switches to a *Help* buffer describing variable-pitch >> face, containing the line >> Slant: unspecified >> i.e., this is not the face that I clicked to get a description of (as >> the tooltip also promises). Wouldn't it be better (if readily >> implementable) to exclude `(:slant oblique)' from the the describe-face >> link? > > The "face" you are trying to customize is actually two faces---the > `variable-pitch' face plus an anonymous face consisting of the > property-value pair (:slant oblique). I was obviously confused above, but I also think it's confusing to say there are two faces here and to call `(:slant oblique)' an anonymous face. `(variable-pitch (:slant oblique))' is simply the value of the face property (as indeed the *Help* buffer explicitly says; I don't know why I was confused). > The best that Custom can do is to > allow you to customize the former. The latter can't be customized > because it lacks a face name (how would we save the customized face?). Since the value of the face property can contain named faces, I expect these to be customizable, and indeed, when I type `C-u C-x =' on the `A' of `Authors' in the *About GNU Emacs* buffer, the *Help* buffer shows this: There are text properties here: face (link variable-pitch) and when I click on this value I do indeed get a buffer describing both the link and variable-pitch faces, each with an accompanying customize button. Since `(:slant oblique)' in the previous case is not a named face, it cannot, as you say, be customized. But for this reason, I think it would be better, as I suggested, to have `(:slant oblique)' not be clickable in the output of `C-u C-x ='. I found two other cases that seem buggy: (a) Type `C-u C-x =' on any of the letters in `GNU Emacs' or `GNU/Linux' in the line directly below the Emacs logo in the *About GNU Emacs* buffer. The resulting *Help* buffer shows this as the value of the face property: face (link (variable-pitch (:foreground "red"))) This is not a valid value of the face property; instead, it should be this: face (link variable-pitch (:foreground "red")) Moreover, I would expect clicking on the value to show me descriptions of the link and variable-pitch faces, as above. Instead, there is only a description of the link face. (I would recommend two clickable links here, one for each named face, and none for the property-value pair.) (b) In a Text mode buffer, mark a region of text, click the menu entry Edit->Text Properties->Foreground Color->red, and on one of the resulting red characters type `C-u C-x ='. The *Help* buffers shows: face ((:foreground "red")) which is fine, but when I click on the value, I get an empty *Help* buffer. This is another reason for this type of face value not to be overlayed with a clickable link. Steve Berman