From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Tobias C. Rittweiler" Newsgroups: gmane.emacs.devel Subject: Comments on misearch.el Date: Tue, 17 Nov 2009 16:22:25 +0100 Message-ID: <87iqd9mb0u.fsf@freebits.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1258471576 21170 80.91.229.12 (17 Nov 2009 15:26:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Nov 2009 15:26:16 +0000 (UTC) Cc: Juri Linkov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 17 16:26:09 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NAPwO-0003Ij-Ns for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2009 16:26:00 +0100 Original-Received: from localhost ([127.0.0.1]:34770 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAPwO-0007t8-3H for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2009 10:26:00 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAPuI-0006cq-PV for emacs-devel@gnu.org; Tue, 17 Nov 2009 10:23:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAPuD-0006aZ-4a for emacs-devel@gnu.org; Tue, 17 Nov 2009 10:23:49 -0500 Original-Received: from [199.232.76.173] (port=36711 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAPuC-0006aP-Tn for emacs-devel@gnu.org; Tue, 17 Nov 2009 10:23:44 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:37447) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NAPuC-0006N3-Bt for emacs-devel@gnu.org; Tue, 17 Nov 2009 10:23:44 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1NAPts-0001r4-I5 for emacs-devel@gnu.org; Tue, 17 Nov 2009 16:23:24 +0100 Original-Received: from host146.natpool.mwn.de ([138.246.7.146]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 17 Nov 2009 16:23:24 +0100 Original-Received: from tcr by host146.natpool.mwn.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 17 Nov 2009 16:23:24 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 52 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: host146.natpool.mwn.de User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:h1iL7Eb+lsYf65TI/dyb9q0G0zI= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:117100 Archived-At: I just tried misearch.el which provides the ability to search through multiple files / buffers via isearch. Thank you, Juri, for writing it, it's exactly what I need. (BTW., is there something like misearch but for query-replace, too?) I do have some comments on it: * The docstring of `multi-isearch-next-buffer-function' says that the function is called with the current buffer as first argument. However, in case of the initial buffer, it's actually called with `nil' as first argument. Is that intended? If so, the docstring should reflect that. I now have in my next-buffer function (setq current-buffer (or current-buffer (current-buffer))) as a workaround. * It'd be nice, not only to display "Repeat for next buffer", but actually include the next buffer's name. * If I'm in a file that contains matches, and I'm at the last match, it exhibits the following behaviour in the minibuffer: Multi Isearch: ... (pressing C-s) Failing multi Isearch: ... [Repeat ...] (pressing C-s) jumps to first match in next buffer However, if I'm in a buffer that won't have a match, I see the following behaviour: Multi Isearch: ..(incremently typing).. --> turns to Failing multi Isearch: ... [Repeat ...] (pressing C-s) Failing mutli Isearch: ... (pressing C-s) goes to next file I.e., as you can hopefully see, it expects one C-s too much. (The line without the "[Repeat ...]" is superfluous.) -T.