bug#5279: 23.1; VC: should set LC_MESSAGES to C (with patch)

bug#5279: 23.1; VC: should set LC_MESSAGES to C (with patch)

[Frédéric Perrin]

Hello,

I'm using emacs with LANG=fr_FR.UTF-8. When using C-x v + (`vc-update')
on a file versionned with SVN, emacs barfs saying it can't parse the
output from "svn update". Indeed, SVN said "À la révision 123" whereas
"At revision 123" was expected. The following patch adds "LC_MESSAGES=C"
to process-environment before calling external tools; this solves the
problem for my case.

--- /root/backups/!usr!share!emacs!23.1!lisp!vc-dispatcher.el.gz.~1~
+++ /usr/share/emacs/23.1/lisp/vc-dispatcher.el.gz
@@ -318,11 +318,14 @@
 	  (setq squeezed (nconc squeezed files)))
 	(let ((exec-path (append vc-path exec-path))
 	      ;; Add vc-path to PATH for the execution of this command.
+	      ;; Also, since some functions need to parse the output from
+	      ;; external commands, set LC_MESSAGES to C.
 	      (process-environment
-	       (cons (concat "PATH=" (getenv "PATH")
-			     path-separator
-			     (mapconcat 'identity vc-path path-separator))
-		     process-environment))
+	       (append (list (concat "PATH=" (getenv "PATH")
+				     path-separator
+				     (mapconcat 'identity vc-path path-separator))
+			     "LC_MESSAGES=C")
+		       process-environment))
 	      (w32-quote-process-args t))
 	  (if (eq okstatus 'async)
 	      ;; Run asynchronously.



In GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-07-31 on shirley.hoetzel.info
Windowing system distributor `The X.Org Foundation', version 11.0.10703901
configured using `configure  '--prefix=/usr' '--sysconfdir=/etc' '--libexecdir=/usr/lib' '--localstatedir=/var' '--mandir=/usr/share/man' '--without-sound' '-with-x-toolkit=gtk' 'CFLAGS=-march=i686 -mtune=generic -O2 -pipe''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: fr_FR.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: C/l

Minor modes in effect:
  diff-auto-refine-mode: t
  shell-dirtrack-mode: t
  show-paren-mode: t
  global-hi-lock-mode: t
  hi-lock-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
c r <return> <return> <return> ( f i n d - b u f f 
<M-tab> SPC " " <left> f s h . c e <backspace> C-e 
) C-x C-e <left> <left> <left> <left> <left> <left> 
<left> / d o n n e e s / s r c / f s h / C-e C-x C-e 
C-x b <return> C-x b v c - <return> <up> <C-right> 
<C-right> <C-right> <C-right> <C-backspace> <backspace> 
<C-left> ( f i n d - b u f f e r - v i s i t i n g 
SPC C-e ) C-x C-s C-M-x <up> <up> <up> <up> <up> <up> 
<up> <up> <up> C-M-x <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> C-e 
<left> <left> C-x C-e C-x C-e C-x b f s <return> C-x 
v = q C-x o <down> <down> <C-right> <C-right> <up> 
<right> <right> <right> <right> <right> <backspace> 
<backspace> <backspace> r C-x v = C-x o <backspace> 
<backspace> <backspace> <backspace> <backspace> o u 
h SPC ! C-x C-s M-x e s <tab> <return> l s <return> 
r m SPC f <tab> <tab> <return> C-x b <return> C-x v 
= n k <escape> x v c - d <tab> <backspace> p a r <tab> 
- c <tab> <return> C-x b d i f <return> C-x b <return> 
B e u h - <backspace> SPC - > SPC b o u h . C-c C-c 
<C-up> <C-up> <C-up> <C-up> <C-up> <C-down> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <down> 
<down> C-x b C-g <return> <backspace> C-x C-s C-x b 
C-g C-g C-x v = n <return> C-x o C-x b v c - p <return> 
<help-echo> C-x o C-_ C-_ C-_ <C-down> <C-down> <escape> 
x r e p o <tab> r <tab> <return>

Recent messages:
Saving file /donnees/src/fsh/fsh.c...
Wrote /donnees/src/fsh/fsh.c
Quit [2 times]
Finding changes in /donnees/src/fsh/fsh.c...done
Mark set
Hunk already applied
Undo! [2 times]
undo-more: No further undo information
Auto-saving...done
Making completion list...

-- 
Fred

bug#5279: 23.1; VC: should set LC_MESSAGES to C (with patch)

[Chong Yidong]

> I'm using emacs with LANG=fr_FR.UTF-8. When using C-x v +
> (`vc-update') on a file versionned with SVN, emacs barfs saying it
> can't parse the output from "svn update". Indeed, SVN said "À la
> révision 123" whereas "At revision 123" was expected. The following
> patch adds "LC_MESSAGES=C" to process-environment before calling
> external tools; this solves the problem for my case.

Thanks, the patch looks good.  I've checked it into the Emacs
repository.