From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#5601: 23.1; etags Scheme_functions past \0 terminator Date: Sat, 20 Feb 2010 09:12:26 -0500 Message-ID: <87iq9s0zed.fsf@stupidchicken.com> References: <87eikiaxqf.fsf@blah.blah> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1266675813 20049 80.91.229.12 (20 Feb 2010 14:23:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Feb 2010 14:23:33 +0000 (UTC) Cc: Kevin Ryde , 5601@debbugs.gnu.org To: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 20 15:23:31 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NiqF0-0007Wq-MN for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Feb 2010 15:23:30 +0100 Original-Received: from localhost ([127.0.0.1]:43643 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiqEz-0003qG-Tu for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Feb 2010 09:23:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiqEb-0003jX-Je for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2010 09:23:05 -0500 Original-Received: from [140.186.70.92] (port=52680 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiqEZ-0003ip-BX for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2010 09:23:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NiqEX-0003Go-Cz for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2010 09:23:03 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52632) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NiqEX-0003Gk-AN for bug-gnu-emacs@gnu.org; Sat, 20 Feb 2010 09:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Niq4s-0004Wz-1R; Sat, 20 Feb 2010 09:13:02 -0500 X-Loop: bug-gnu-emacs@gnu.org In-Reply-To: <87eikiaxqf.fsf@blah.blah> Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Feb 2010 14:13:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5601 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5601-submit@debbugs.gnu.org id=B5601.126667515517393 (code B ref 5601); Sat, 20 Feb 2010 14:13:02 +0000 Original-Received: (at 5601) by debbugs.gnu.org; 20 Feb 2010 14:12:35 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Niq4Q-0004WU-R8 for submit@debbugs.gnu.org; Sat, 20 Feb 2010 09:12:35 -0500 Original-Received: from pantheon-po34.its.yale.edu ([130.132.50.80]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Niq4O-0004WL-Ol for 5601@debbugs.gnu.org; Sat, 20 Feb 2010 09:12:32 -0500 Original-Received: from furry (adsl-99-96-75-7.dsl.wlfrct.sbcglobal.net [99.96.75.7]) (authenticated bits=0) by pantheon-po34.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o1KECQZS026756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 20 Feb 2010 09:12:27 -0500 Original-Received: by furry (Postfix, from userid 1000) id 5C792C05D; Sat, 20 Feb 2010 09:12:26 -0500 (EST) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 20 Feb 2010 09:13:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:35212 Archived-At: > >In etags.c Scheme_functions, I think the loop > > > > while (notinname (*bp)) > > bp++; > > > >will take bp past the '\0' string terminator, because '\0' is a > >notinname(). > > Yes, it appears so. This is a long-standing bug. Thanks for spotting > it. > > >(Another helper skip_notinname() to try to be clearer > >than a double-negative loop :-) > > I don't think a helper function is granted here. There is a single use > of this construct in the file, and a lot of different constructs: we > have not a helper function for each of them. I've checked in the patch, without the helper function. Thanks.