all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: "Francesco Potortì" <pot@gnu.org>
Cc: Kevin Ryde <user42@zip.com.au>, 5601@debbugs.gnu.org
Subject: bug#5601: 23.1; etags Scheme_functions past \0 terminator
Date: Sat, 20 Feb 2010 09:12:26 -0500	[thread overview]
Message-ID: <87iq9s0zed.fsf@stupidchicken.com> (raw)
In-Reply-To: <87eikiaxqf.fsf@blah.blah>

> >In etags.c Scheme_functions, I think the loop
> >
> >    while (notinname (*bp))
> >      bp++;
> >
> >will take bp past the '\0' string terminator, because '\0' is a
> >notinname().
>
> Yes, it appears so.  This is a long-standing bug.  Thanks for spotting
> it.
>
> >(Another helper skip_notinname() to try to be clearer
> >than a double-negative loop :-)
>
> I don't think a helper function is granted here.  There is a single use
> of this construct in the file, and a lot of different constructs: we
> have not a helper function for each of them.

I've checked in the patch, without the helper function.  Thanks.






      parent reply	other threads:[~2010-02-20 14:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19  0:13 bug#5601: 23.1; etags Scheme_functions past \0 terminator Kevin Ryde
2010-02-19  9:39 ` Francesco Potortì
2010-02-20 14:12 ` Chong Yidong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iq9s0zed.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=5601@debbugs.gnu.org \
    --cc=pot@gnu.org \
    --cc=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.