From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#7438: 23.2; [PATCH] lisp/gnus/pop3.el fix STLS command ordering Date: Fri, 19 Nov 2010 11:25:27 -0500 Message-ID: <87ipztp9fs.fsf@stupidchicken.com> References: <874obe44r9.fsf@askold.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1290185093 31534 80.91.229.12 (19 Nov 2010 16:44:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 19 Nov 2010 16:44:53 +0000 (UTC) Cc: 7438@debbugs.gnu.org To: Yuri Karaban Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 19 17:44:48 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PJU4r-0008IA-F1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Nov 2010 17:44:45 +0100 Original-Received: from localhost ([127.0.0.1]:37737 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJU4q-0000mT-Al for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Nov 2010 11:44:44 -0500 Original-Received: from [140.186.70.92] (port=47949 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJU4f-0000lL-3l for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2010 11:44:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJU4d-0005um-Kn for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2010 11:44:32 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJU4d-0005uf-Gi for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2010 11:44:31 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PJThu-0008Kf-9j; Fri, 19 Nov 2010 11:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 19 Nov 2010 16:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7438 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 7438-submit@debbugs.gnu.org id=B7438.129018362532012 (code B ref 7438); Fri, 19 Nov 2010 16:21:02 +0000 Original-Received: (at 7438) by debbugs.gnu.org; 19 Nov 2010 16:20:25 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PJThI-0008KG-5u for submit@debbugs.gnu.org; Fri, 19 Nov 2010 11:20:24 -0500 Original-Received: from pantheon-po42.its.yale.edu ([130.132.50.101]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PJThG-0008KB-61 for 7438@debbugs.gnu.org; Fri, 19 Nov 2010 11:20:22 -0500 Original-Received: from furball (dhcp128036014113.central.yale.edu [128.36.14.113]) (authenticated bits=0) by pantheon-po42.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id oAJGPR4g021106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 19 Nov 2010 11:25:27 -0500 Original-Received: by furball (Postfix, from userid 1000) id 18AEF160854; Fri, 19 Nov 2010 11:25:28 -0500 (EST) In-Reply-To: <874obe44r9.fsf@askold.net> (Yuri Karaban's message of "Fri, 19 Nov 2010 00:59:54 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 19 Nov 2010 11:21:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41751 Archived-At: Yuri Karaban writes: > Starttls (STLS) is not working with pop3. > > There is a bug in current implementation. > > Current implementation sends STLS just after opening connection. > > As result connection hangs (pop3.el tries to read a greeting message > after STLS, but all POP3 servers I tried does not send anything after > successful negotiation). On other hand, ignoring server greeting leads > to mistreating server greeting (+OK ) as successful response > to STLS command. In this case negotiation starts too early (before > reading real response to STLS). > > I've attached a patch which fixes the problem. The server greeting got > read first (as with plain POP3) and only after receiving greeting STLS > issued and TLS negotiation starts. > > I hope much this would be fixed in next minor release of emacs. Looks reasonable. I've checked your patch into the emacs-23 branch. Thanks.